RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:37:35 +00:00
Code Issues Activity Actions

Userland/cp: Disallow copying directories into themselves

Browse source 
This patch causes cp to investigate whether a directory is being copied
into a subdirectory of itself. It uses realpath(3) to ensure that links
do not confound detection.
This commit is contained in:
Matthew L. Curry 2020-10-11 05:02:24 -06:00 • committed by Andreas Kling
parent d94f674bbb
commit 909687ddf0
1 changed files with 11 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/cp.cpp
View file

@ -29,6 +29,7 @@
#include <AK/StringBuilder.h>
#include <LibCore/ArgsParser.h>
#include <LibCore/DirIterator.h>
#include <LibCore/File.h>
#include <assert.h>
#include <fcntl.h>
#include <stdio.h>
@ -174,6 +175,16 @@ bool copy_directory(String src_path, String dst_path)
perror("cp: mkdir");
return false;
}
String src_rp = Core::File::real_path_for(src_path);
String dst_rp = Core::File::real_path_for(dst_path);
if (!dst_rp.is_empty() && dst_rp.starts_with(src_rp)) {
fprintf(stderr, "cp: Cannot copy %s into itself (%s)\n",
src_path.characters(), dst_path.characters());
return false;
}
Core::DirIterator di(src_path, Core::DirIterator::SkipDots);
if (di.has_error()) {
fprintf(stderr, "cp: DirIterator: %s\n", di.error_string());