RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 22:28:11 +00:00
Code Issues Activity Actions

Kernel: Fix boot profiling

Browse source 
Boot profiling was previously broken due to init_stage2() passing the
event mask to sys$profiling_enable() via kernel pointer, but a user
pointer is expected.

To fix this, I added Process::profiling_enable() as an alternative to
Process::sys$profiling_enable which takes a u64 rather than a
Userspace<u64 const*>. It's a bit of a hack, but it works.
This commit is contained in:
Samuel Bowman 2022-08-20 21:55:55 -04:00 • committed by Andreas Kling
parent 0abe4d8b97
commit 91574ed677
3 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Kernel/Syscalls/profiling.cpp
View file

@ -24,6 +24,13 @@ ErrorOr<FlatPtr> Process::sys$profiling_enable(pid_t pid, Userspace<u64 const*>
TRY(require_no_promises());
auto const event_mask = TRY(copy_typed_from_user(userspace_event_mask));
return profiling_enable(pid, event_mask);
}
// NOTE: This second entrypoint exists to allow the kernel to invoke the syscall to enable boot profiling.
ErrorOr<FlatPtr> Process::profiling_enable(pid_t pid, u64 event_mask)
{
VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this);
if (pid == -1) {
auto credentials = this->credentials();