RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:27:45 +00:00
Code Issues Activity Actions

LibJS: Inline Cell::Visitor::visit() functions

Browse source 
This allows the calls to MarkingVisitor::visit_impl() during GC to be
devirtualized in Heap::mark_live_cells().
This commit is contained in:
Andreas Kling 2021-05-25 18:17:41 +02:00
parent c81b3e1ee3
commit 91656d63c7
4 changed files with 11 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibJS/CMakeLists.txt
View file

@ -2,7 +2,6 @@ set(SOURCES
AST.cpp AST.cpp
Console.cpp Console.cpp
Heap/Allocator.cpp Heap/Allocator.cpp
Heap/Cell.cpp
Heap/Handle.cpp Heap/Handle.cpp
Heap/HeapBlock.cpp Heap/HeapBlock.cpp
Heap/Heap.cpp Heap/Heap.cpp

26
Userland/Libraries/LibJS/Heap/Cell.cpp
View file

@ -1,26 +0,0 @@
/*
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibJS/Heap/Cell.h>
#include <LibJS/Heap/Heap.h>
#include <LibJS/Heap/HeapBlock.h>
#include <LibJS/Runtime/Value.h>
namespace JS {
void Cell::Visitor::visit(Cell* cell)
{
if (cell)
visit_impl(cell);
}
void Cell::Visitor::visit(Value value)
{
if (value.is_cell())
visit_impl(value.as_cell());
}
}

6
Userland/Libraries/LibJS/Heap/Cell.h
View file

@ -33,7 +33,11 @@ public:
class Visitor { class Visitor {
public: public:
void visit(Cell*); void visit(Cell* cell)
{
if (cell)
visit_impl(cell);
}
void visit(Value); void visit(Value);
protected: protected:

6
Userland/Libraries/LibJS/Runtime/Value.h
View file

@ -327,6 +327,12 @@ inline Value js_negative_infinity()
return Value(-INFINITY); return Value(-INFINITY);
} }
inline void Cell::Visitor::visit(Value value)
{
if (value.is_cell())
visit_impl(value.as_cell());
}
Value greater_than(GlobalObject&, Value lhs, Value rhs); Value greater_than(GlobalObject&, Value lhs, Value rhs);
Value greater_than_equals(GlobalObject&, Value lhs, Value rhs); Value greater_than_equals(GlobalObject&, Value lhs, Value rhs);
Value less_than(GlobalObject&, Value lhs, Value rhs); Value less_than(GlobalObject&, Value lhs, Value rhs);