From 9174ffd7e6be9a1014cd424869260c0b22aee500 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Tue, 11 Jul 2023 18:43:33 +0200 Subject: [PATCH] LibWeb: Create Layout::Box for `display: inline-grid` This makes us actually run a GridFormattingContext instead of rendering inline-grid elements as nothing. :^) --- .../LibWeb/Layout/expected/grid/inline-grid-simple.txt | 10 ++++++++++ Tests/LibWeb/Layout/input/grid/inline-grid-simple.html | 5 +++++ Userland/Libraries/LibWeb/DOM/Element.cpp | 2 ++ 3 files changed, 17 insertions(+) create mode 100644 Tests/LibWeb/Layout/expected/grid/inline-grid-simple.txt create mode 100644 Tests/LibWeb/Layout/input/grid/inline-grid-simple.html diff --git a/Tests/LibWeb/Layout/expected/grid/inline-grid-simple.txt b/Tests/LibWeb/Layout/expected/grid/inline-grid-simple.txt new file mode 100644 index 0000000000..25a1469c5c --- /dev/null +++ b/Tests/LibWeb/Layout/expected/grid/inline-grid-simple.txt @@ -0,0 +1,10 @@ +Viewport <#document> at (0,0) content-size 800x600 children: not-inline + BlockContainer at (0,0) content-size 800x33.46875 [BFC] children: inline + line 0 width: 42.953125, height: 33.46875, bottom: 33.46875, baseline: 13.53125 + frag 0 from Box start: 0, length: 0, rect: [8,8 26.953125x17.46875] + Box at (8,8) content-size 26.953125x17.46875 [GFC] children: not-inline + BlockContainer <(anonymous)> at (8,8) content-size 26.953125x17.46875 [BFC] children: inline + line 0 width: 26.953125, height: 17.46875, bottom: 17.46875, baseline: 13.53125 + frag 0 from TextNode start: 0, length: 3, rect: [8,8 26.953125x17.46875] + "whf" + TextNode <#text> diff --git a/Tests/LibWeb/Layout/input/grid/inline-grid-simple.html b/Tests/LibWeb/Layout/input/grid/inline-grid-simple.html new file mode 100644 index 0000000000..1ac9bef303 --- /dev/null +++ b/Tests/LibWeb/Layout/input/grid/inline-grid-simple.html @@ -0,0 +1,5 @@ +whf \ No newline at end of file diff --git a/Userland/Libraries/LibWeb/DOM/Element.cpp b/Userland/Libraries/LibWeb/DOM/Element.cpp index bf742ac6f3..d1d9452d51 100644 --- a/Userland/Libraries/LibWeb/DOM/Element.cpp +++ b/Userland/Libraries/LibWeb/DOM/Element.cpp @@ -338,6 +338,8 @@ JS::GCPtr Element::create_layout_node_for_display_type(DOM::Docume return document.heap().allocate_without_realm(document, element, move(style)); if (display.is_flex_inside()) return document.heap().allocate_without_realm(document, element, move(style)); + if (display.is_grid_inside()) + return document.heap().allocate_without_realm(document, element, move(style)); dbgln_if(LIBWEB_CSS_DEBUG, "FIXME: Support display: {}", MUST(display.to_string())); return document.heap().allocate_without_realm(document, element, move(style)); }