RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 21:27:34 +00:00
Code Issues Activity Actions

LibGfx: Clamp coordinates for bilinear blending correctly

Browse source 
Clamp these coordinates based on the src_rect's top/right/bottom/left
instead of assuming src_rect is positioned at 0,0
This commit is contained in:
Simon Wanner 2022-03-21 00:08:52 +01:00 • committed by Andreas Kling
parent 8f1a3f7878
commit 917d06fa30
1 changed files with 13 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibGfx/Painter.cpp
View file

@ -1128,15 +1128,23 @@ ALWAYS_INLINE static void do_draw_scaled_bitmap(Gfx::Bitmap& target, IntRect con
Color src_pixel; Color src_pixel;
if constexpr (do_bilinear_blend) { if constexpr (do_bilinear_blend) {
auto scaled_x0 = clamp((desired_x - half_pixel) >> 32, 0, src_rect.width() - 1); auto scaled_x0 = clamp((desired_x - half_pixel) >> 32, src_rect.left(), src_rect.right());
auto scaled_x1 = clamp((desired_x + half_pixel) >> 32, 0, src_rect.width() - 1); auto scaled_x1 = clamp((desired_x + half_pixel) >> 32, src_rect.left(), src_rect.right());
auto scaled_y0 = clamp((desired_y - half_pixel) >> 32, 0, src_rect.height() - 1); auto scaled_y0 = clamp((desired_y - half_pixel) >> 32, src_rect.top(), src_rect.bottom());
auto scaled_y1 = clamp((desired_y + half_pixel) >> 32, 0, src_rect.height() - 1); auto scaled_y1 = clamp((desired_y + half_pixel) >> 32, src_rect.top(), src_rect.bottom());
float x_ratio = (((desired_x + half_pixel) & fractional_mask) / (float)shift); float x_ratio = (((desired_x + half_pixel) & fractional_mask) / (float)shift);
float y_ratio = (((desired_y + half_pixel) & fractional_mask) / (float)shift); float y_ratio = (((desired_y + half_pixel) & fractional_mask) / (float)shift);
src_pixel = get_pixel(source, scaled_x0, scaled_y0).interpolate(get_pixel(source, scaled_x1, scaled_y0), x_ratio).interpolate(get_pixel(source, scaled_x0, scaled_y1).interpolate(get_pixel(source, scaled_x1, scaled_y1), x_ratio), y_ratio); auto top_left = get_pixel(source, scaled_x0, scaled_y0);
auto top_right = get_pixel(source, scaled_x1, scaled_y0);
auto bottom_left = get_pixel(source, scaled_x0, scaled_y1);
auto bottom_right = get_pixel(source, scaled_x1, scaled_y1);
auto top = top_left.interpolate(top_right, x_ratio);
auto bottom = bottom_left.interpolate(bottom_right, x_ratio);
src_pixel = top.interpolate(bottom, y_ratio);
} else { } else {
auto scaled_x = desired_x >> 32; auto scaled_x = desired_x >> 32;
auto scaled_y = desired_y >> 32; auto scaled_y = desired_y >> 32;