RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 19:47:46 +00:00
Code Issues Activity Actions

Everywhere: Add Alt shortcuts to remaining top-level menus

Browse source 
Not sure why some menus did have one and others didn't, even in the
same application - now they all do. :^)
I added character shortcuts to some menu actions as well.
This commit is contained in:
Linus Groh 2021-05-12 18:09:42 +01:00
parent f2154bca17
commit 91eda22208
23 changed files with 49 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Applications/DisplaySettings/main.cpp
View file

@ -48,12 +48,12 @@ int main(int argc, char** argv)
auto menubar = GUI::Menubar::construct();
auto& file_menu = menubar->add_menu("File");
auto& file_menu = menubar->add_menu("&File");
file_menu.add_action(GUI::CommonActions::make_quit_action([&](const GUI::Action&) {
app->quit();
}));
auto& help_menu = menubar->add_menu("Help");
auto& help_menu = menubar->add_menu("&Help");
help_menu.add_action(GUI::CommonActions::make_about_action("Display Settings", app_icon, window));
window->set_menubar(move(menubar));

2
Userland/Applications/Help/main.cpp
View file

@ -261,7 +261,7 @@ int main(int argc, char* argv[])
GUI::Application::the()->quit();
}));
auto& go_menu = menubar->add_menu("Go");
auto& go_menu = menubar->add_menu("&Go");
go_menu.add_action(*go_back_action);
go_menu.add_action(*go_forward_action);
go_menu.add_action(*go_home_action);

2
Userland/Applications/IRCClient/IRCAppWindow.cpp
View file

@ -243,7 +243,7 @@ void IRCAppWindow::setup_menus()
GUI::Application::the()->quit();
}));
auto& server_menu = menubar->add_menu("Server");
auto& server_menu = menubar->add_menu("&Server");
server_menu.add_action(*m_change_nick_action);
server_menu.add_separator();
server_menu.add_action(*m_join_action);

2
Userland/Applications/KeyboardMapper/main.cpp
View file

@ -93,7 +93,7 @@ int main(int argc, char** argv)
file_menu.add_separator();
file_menu.add_action(quit_action);
auto& help_menu = menubar->add_menu("Help");
auto& help_menu = menubar->add_menu("&Help");
help_menu.add_action(GUI::CommonActions::make_about_action("Keyboard Mapper", app_icon, window));
window->set_menubar(move(menubar));

4
Userland/Applications/KeyboardSettings/main.cpp
View file

@ -168,10 +168,10 @@ int main(int argc, char** argv)
auto menubar = GUI::Menubar::construct();
auto& file_menu = menubar->add_menu("File");
auto& file_menu = menubar->add_menu("&File");
file_menu.add_action(quit_action);
auto& help_menu = menubar->add_menu("Help");
auto& help_menu = menubar->add_menu("&Help");
help_menu.add_action(GUI::CommonActions::make_about_action("Keyboard Settings", app_icon, window));
window->set_menubar(move(menubar));

5
Userland/Applications/MouseSettings/main.cpp
View file

@ -37,13 +37,14 @@ int main(int argc, char** argv)
window->set_icon(app_icon.bitmap_for_size(16));
auto menubar = GUI::Menubar::construct();
auto& file_menu = menubar->add_menu("File");
auto& file_menu = menubar->add_menu("&File");
file_menu.add_action(GUI::CommonActions::make_quit_action([&](auto&) {
app->quit();
}));
auto& help_menu = menubar->add_menu("Help");
auto& help_menu = menubar->add_menu("&Help");
help_menu.add_action(GUI::CommonActions::make_about_action("Mouse Settings", app_icon, window));
window->set_menubar(move(menubar));
window->show();

6
Userland/Applications/Piano/main.cpp
View file

@ -91,7 +91,7 @@ int main(int argc, char** argv)
auto menubar = GUI::Menubar::construct();
auto& file_menu = menubar->add_menu("File");
auto& file_menu = menubar->add_menu("&File");
file_menu.add_action(GUI::Action::create("Export", { Mod_Ctrl, Key_E }, [&](const GUI::Action&) {
save_path = GUI::FilePicker::get_save_filepath(window, "Untitled", "wav");
if (!save_path.has_value())
@ -110,10 +110,10 @@ int main(int argc, char** argv)
return;
}));
auto& edit_menu = menubar->add_menu("Edit");
auto& edit_menu = menubar->add_menu("&Edit");
main_widget.add_actions(edit_menu);
auto& help_menu = menubar->add_menu("Help");
auto& help_menu = menubar->add_menu("&Help");
help_menu.add_action(GUI::CommonActions::make_about_action("Piano", app_icon, window));
window->set_menubar(move(menubar));

8
Userland/Applications/SoundPlayer/main.cpp
View file

@ -62,7 +62,7 @@ int main(int argc, char** argv)
auto& file_menu = menubar->add_menu("&File");
auto& playlist_menu = menubar->add_menu("Playlist");
auto& playlist_menu = menubar->add_menu("Play&list");
String path = argv[1];
// start in advanced view by default
@ -101,7 +101,7 @@ int main(int argc, char** argv)
app->quit();
}));
auto& playback_menu = menubar->add_menu("Playback");
auto& playback_menu = menubar->add_menu("&Playback");
auto loop = GUI::Action::create_checkable("Loop", { Mod_Ctrl, Key_R }, [&](auto& action) {
player->set_looping_file(action.is_checked());
@ -109,7 +109,7 @@ int main(int argc, char** argv)
playback_menu.add_action(move(loop));
auto& visualization_menu = menubar->add_menu("Visualization");
auto& visualization_menu = menubar->add_menu("&Visualization");
Vector<NonnullRefPtr<GUI::Action>> visualization_checkmarks;
GUI::Action* checked_vis = nullptr;
auto uncheck_all_but = [&](GUI::Action& one) {for (auto& a : visualization_checkmarks) if (a != &one) a->set_checked(false); };
@ -154,7 +154,7 @@ int main(int argc, char** argv)
visualization_menu.add_action(none);
visualization_checkmarks.append(none);
auto& help_menu = menubar->add_menu("Help");
auto& help_menu = menubar->add_menu("&Help");
help_menu.add_action(GUI::CommonActions::make_about_action("Sound Player", app_icon, window));
window->set_menubar(move(menubar));

6
Userland/Applications/SpaceAnalyzer/main.cpp
View file

@ -269,8 +269,8 @@ int main(int argc, char* argv[])
auto& treemapwidget = *mainwidget.find_descendant_of_type_named<SpaceAnalyzer::TreeMapWidget>("tree_map");
auto& statusbar = *mainwidget.find_descendant_of_type_named<GUI::Statusbar>("statusbar");
// Configure the menubar.
auto menubar = GUI::Menubar::construct();
auto& file_menu = menubar->add_menu("&File");
file_menu.add_action(GUI::Action::create("&Analyze", [&](auto&) {
analyze(tree, treemapwidget, statusbar);
@ -278,8 +278,10 @@ int main(int argc, char* argv[])
file_menu.add_action(GUI::CommonActions::make_quit_action([&](auto&) {
app->quit();
}));
auto& help_menu = menubar->add_menu("Help");
auto& help_menu = menubar->add_menu("&Help");
help_menu.add_action(GUI::CommonActions::make_about_action(APP_NAME, app_icon, window));
window->set_menubar(move(menubar));
// Configure the nodes context menu.

4
Userland/Applications/Spreadsheet/main.cpp
View file

@ -143,7 +143,7 @@ int main(int argc, char* argv[])
return GUI::Window::CloseRequestDecision::StayOpen;
};
auto& edit_menu = menubar->add_menu("Edit");
auto& edit_menu = menubar->add_menu("&Edit");
auto clipboard_action = [&](bool is_cut) {
/// text/x-spreadsheet-data:
@ -233,7 +233,7 @@ int main(int argc, char* argv[])
},
window));
auto& help_menu = menubar->add_menu("Help");
auto& help_menu = menubar->add_menu("&Help");
help_menu.add_action(GUI::Action::create(
"Functions Help", [&](auto&) {