1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 21:57:35 +00:00

LibJS: Add LoadArgument bytecode instruction for fast argument access

This is generated for Identifier nodes that represent a function
argument variable. It loads a given argument index from the current
call frame into the accumulator.
This commit is contained in:
Andreas Kling 2021-06-14 09:37:35 +02:00
parent 848944113c
commit 91fbeeab72
4 changed files with 31 additions and 1 deletions

View file

@ -260,6 +260,9 @@ void StringLiteral::generate_bytecode(Bytecode::Generator& generator) const
void Identifier::generate_bytecode(Bytecode::Generator& generator) const
{
if (m_argument_index.has_value())
generator.emit<Bytecode::Op::LoadArgument>(m_argument_index.value());
else
generator.emit<Bytecode::Op::GetVariable>(generator.intern_string(m_string));
}

View file

@ -61,6 +61,7 @@
O(Decrement) \
O(Throw) \
O(PushLexicalEnvironment) \
O(LoadArgument) \
O(EnterUnwindContext) \
O(LeaveUnwindContext) \
O(ContinuePendingUnwind) \

View file

@ -311,6 +311,11 @@ void PutByValue::execute(Bytecode::Interpreter& interpreter) const
}
}
void LoadArgument::execute(Bytecode::Interpreter& interpreter) const
{
interpreter.accumulator() = interpreter.vm().argument(m_index);
}
String Load::to_string(Bytecode::Executable const&) const
{
return String::formatted("Load {}", m_src);
@ -493,4 +498,9 @@ String PutByValue::to_string(const Bytecode::Executable&) const
return String::formatted("PutByValue base:{}, property:{}", m_base, m_property);
}
String LoadArgument::to_string(const Bytecode::Executable&) const
{
return String::formatted("LoadArgument {}", m_index);
}
}

View file

@ -529,6 +529,22 @@ public:
private:
HashMap<u32, Variable> m_variables;
};
class LoadArgument final : public Instruction {
public:
explicit LoadArgument(size_t index)
: Instruction(Type::LoadArgument)
, m_index(index)
{
}
void execute(Bytecode::Interpreter&) const;
String to_string(Bytecode::Executable const&) const;
private:
size_t m_index { 0 };
};
}
namespace JS::Bytecode {