1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:57:45 +00:00

Kernel/KCOV: Bring closer to typical SerenityOS coding style

- Remove a bunch of redundant `this->`
- Make class data members private and provide accessors instead
This commit is contained in:
Andreas Kling 2021-09-06 00:31:48 +02:00
parent 79fbad6df9
commit 91fe6b6552
4 changed files with 44 additions and 39 deletions

View file

@ -35,23 +35,30 @@ public:
bool has_buffer() const { return m_buffer != nullptr; }
void buffer_add_pc(u64 pc);
Spinlock lock;
enum {
enum State {
UNUSED = 0,
OPENED = 1,
TRACING = 2,
} state;
} m_state { UNUSED };
RefPtr<Memory::AnonymousVMObject> vmobject;
State state() const { return m_state; }
void set_state(State state) { m_state = state; }
Memory::VMObject* vmobject() { return m_vmobject; }
Spinlock& spinlock() { return m_lock; }
private:
ProcessID m_pid = { 0 };
u64 m_buffer_size_in_entries = { 0 };
size_t m_buffer_size_in_bytes = { 0 };
kcov_pc_t* m_buffer = { nullptr };
ProcessID m_pid { 0 };
u64 m_buffer_size_in_entries { 0 };
size_t m_buffer_size_in_bytes { 0 };
kcov_pc_t* m_buffer { nullptr };
RefPtr<Memory::AnonymousVMObject> m_vmobject;
// Here to ensure it's not garbage collected at the end of open()
OwnPtr<Memory::Region> m_kernel_region;
Spinlock m_lock;
};
}