RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:57:44 +00:00
Code Issues Activity Actions

TextEditor: Don't open files when the user cancelled saving changes

Browse source 
Steps to reproduce:

1. Start TextEditor and make some changes to the document.
2. Try to open an existing file.
3. When prompted choose to save the changes to the existing document.
4. Close the file picker by clicking 'Cancel'.
5. Note how the file was opened anyway and your changes were lost.

Same applies to the 'New File' action.
This commit is contained in:
Gunnar Beutner 2021-06-22 19:22:26 +02:00 • committed by Andreas Kling
parent 92fdc5bd69
commit 928364e102
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Applications/TextEditor/MainWidget.cpp
View file

@ -249,7 +249,7 @@ MainWidget::MainWidget()
auto save_document_first_result = GUI::MessageBox::show(window(), "Save changes to current document first?", "Warning", GUI::MessageBox::Type::Warning, GUI::MessageBox::InputType::YesNoCancel);
if (save_document_first_result == GUI::Dialog::ExecResult::ExecYes)
m_save_action->activate();
if (save_document_first_result == GUI::Dialog::ExecResult::ExecCancel)
if (save_document_first_result != GUI::Dialog::ExecResult::ExecNo && editor().document().is_modified())
return;
}
@ -268,7 +268,7 @@ MainWidget::MainWidget()
auto save_document_first_result = GUI::MessageBox::show(window(), "Save changes to current document first?", "Warning", GUI::MessageBox::Type::Warning, GUI::MessageBox::InputType::YesNoCancel);
if (save_document_first_result == GUI::Dialog::ExecResult::ExecYes)
m_save_action->activate();
if (save_document_first_result == GUI::Dialog::ExecResult::ExecCancel)
if (save_document_first_result != GUI::Dialog::ExecResult::ExecNo && editor().document().is_modified())
return;
}