RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 06:38:10 +00:00
Code Issues Activity Actions

AK: Fix leak in JsonValue::operator=(JsonValue&&).

Browse source 
Amusingly I introduced this leak while explaining that this type of leak is
a common bug, and saying I'm used to looking for it. :^)
This commit is contained in:
Andreas Kling 2019-06-18 09:22:19 +02:00
parent 4147394dcb
commit 92cda74724
1 changed files with 1 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
AK/JsonValue.cpp
View file

@ -53,6 +53,7 @@ JsonValue::JsonValue(JsonValue&& other)
JsonValue& JsonValue::operator=(JsonValue&& other) JsonValue& JsonValue::operator=(JsonValue&& other)
{ {
if (this != &other) { if (this != &other) {
clear();
m_type = exchange(other.m_type, Type::Undefined); m_type = exchange(other.m_type, Type::Undefined);
m_value.as_string = exchange(other.m_value.as_string, nullptr); m_value.as_string = exchange(other.m_value.as_string, nullptr);
} }