RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:47:44 +00:00
Code Issues Activity Actions

useradd: Convert String::format() => String::formatted()

Browse source 
Also make more use of warnln().
This commit is contained in:
Andreas Kling 2021-04-21 22:49:27 +02:00
parent 90ee84621f
commit 931f3c03d0
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Utilities/useradd.cpp
View file

@ -107,21 +107,22 @@ int main(int argc, char** argv)
String home; String home;
if (!home_path) if (!home_path)
home = String::format("/home/%s", username); home = String::formatted("/home/{}", username);
else else
home = home_path; home = home_path;
if (create_home_dir) { if (create_home_dir) {
if (mkdir(home.characters(), 0700) < 0) { if (mkdir(home.characters(), 0700) < 0) {
perror(String::format("failed to create directory %s", home.characters()).characters()); auto saved_errno = errno;
warnln("Failed to create directory {}: {}", home, strerror(saved_errno));
return 12; return 12;
} }
if (chown(home.characters(), static_cast<uid_t>(uid), static_cast<gid_t>(gid)) < 0) { if (chown(home.characters(), static_cast<uid_t>(uid), static_cast<gid_t>(gid)) < 0) {
perror(String::format("failed to chown %s to %u:%u", home.characters(), uid, gid).characters()); warnln("Failed to change owner of {} to {}:{}: {}", home, uid, gid, strerror(errno));
if (rmdir(home.characters()) < 0) { if (rmdir(home.characters()) < 0) {
perror(String::format("failed to rmdir %s", home.characters()).characters()); warnln("Failed to remove directory {}: {}", home, strerror(errno));
return 12; return 12;
} }
return 12; return 12;