RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:47:36 +00:00
Code Issues Activity Actions

LibWeb: Use default equality operators for StyleValue helper structs

Browse source 
Co-authored-by: kleines Filmröllchen <filmroellchen@serenityos.org>
This commit is contained in:
MacDue 2023-02-12 23:25:14 +00:00 • committed by Sam Atkins
parent d00a6ca11f
commit 9337892ce0
2 changed files with 8 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

30
Userland/Libraries/LibWeb/CSS/StyleValue.cpp
View file

@ -1306,31 +1306,6 @@ ErrorOr<String> FilterValueListStyleValue::to_string() const
return builder.to_string();
}
static bool operator==(Filter::Blur const& a, Filter::Blur const& b)
{
return a.radius == b.radius;
}
static bool operator==(Filter::DropShadow const& a, Filter::DropShadow const& b)
{
return a.offset_x == b.offset_x && a.offset_y == b.offset_y && a.radius == b.radius && a.color == b.color;
}
static bool operator==(Filter::HueRotate::Zero const&, Filter::HueRotate::Zero const&)
{
return true;
}
static bool operator==(Filter::Color const& a, Filter::Color const& b)
{
return a.operation == b.operation && a.amount == b.amount;
}
static bool operator==(Filter::HueRotate const& a, Filter::HueRotate const& b)
{
return a.angle == b.angle;
}
bool FilterValueListStyleValue::equals(StyleValue const& other) const
{
if (type() != other.type())
@ -1848,11 +1823,6 @@ ErrorOr<String> LinearGradientStyleValue::to_string() const
return builder.to_string();
}
static bool operator==(EdgeRect const& a, EdgeRect const& b)
{
return a.top_edge == b.top_edge && a.right_edge == b.right_edge && a.bottom_edge == b.bottom_edge && a.left_edge == b.left_edge;
}
bool LinearGradientStyleValue::equals(StyleValue const& other_) const
{
if (type() != other_.type())

9
Userland/Libraries/LibWeb/CSS/StyleValue.h
View file

@ -143,6 +143,7 @@ struct EdgeRect {
Length bottom_edge;
Length left_edge;
Gfx::FloatRect resolved(Layout::Node const&, Gfx::FloatRect) const;
bool operator==(EdgeRect const&) const = default;
};
namespace Filter {
@ -150,6 +151,7 @@ namespace Filter {
struct Blur {
Optional<Length> radius {};
float resolved_radius(Layout::Node const&) const;
bool operator==(Blur const&) const = default;
};
struct DropShadow {
@ -164,13 +166,17 @@ struct DropShadow {
Color color;
};
Resolved resolved(Layout::Node const&) const;
bool operator==(DropShadow const&) const = default;
};
struct HueRotate {
struct Zero { };
struct Zero {
bool operator==(Zero const&) const = default;
};
using AngleOrZero = Variant<Angle, Zero>;
Optional<AngleOrZero> angle {};
float angle_degrees() const;
bool operator==(HueRotate const&) const = default;
};
struct Color {
@ -185,6 +191,7 @@ struct Color {
} operation;
Optional<NumberPercentage> amount {};
float resolved_amount() const;
bool operator==(Color const&) const = default;
};
};