RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:37:35 +00:00
Code Issues Activity Actions

LibVT: Fix triple click behavior

Browse source 
When triple clicking a line in the terminal the selection will span the
whole line. However, after dragging down to lines above/below the
selection will stop at the cursor.

Instead, the expected functionality of triple clicking and dragging is
to select the whole line and any whole lines dragged to after the triple
click.

Previously, the triple line counter would get reset as soon as the whole
line was selected. This patch resets the m_triple_click_timer in the
mouse up event, so that the triple click selecting functionality is
maintained during the entire click event and terminated when the event
is over.
This commit is contained in:
brapru 2022-02-13 11:56:31 -05:00 • committed by Andreas Kling
parent 197ebe3433
commit 93496af02b
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibVT/TerminalWidget.cpp
View file

@ -776,6 +776,10 @@ void TerminalWidget::mouseup_event(GUI::MouseEvent& event)
m_active_href_id = {};
update();
}
if (m_triple_click_timer.is_valid())
m_triple_click_timer.reset();
set_auto_scroll_direction(AutoScrollDirection::None);
}
}
@ -809,7 +813,6 @@ void TerminalWidget::mousedown_event(GUI::MouseEvent& event)
else if (m_rectangle_selection)
m_rectangle_selection = false;
m_triple_click_timer.reset();
update_copy_action();
update();
}