RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:57:34 +00:00
Code Issues Activity Actions

LibJS: Remove type assertion comment from IsValidISODate

Browse source 
This is an editorial change in the Temporal spec.

See: ddb5652
This commit is contained in:
Linus Groh 2022-05-06 19:34:59 +02:00
parent 15fe6297bc
commit 938e68d003
1 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibJS/Runtime/Temporal/PlainDate.cpp
View file

@ -374,24 +374,22 @@ ThrowCompletionOr<ISODate> regulate_iso_date(GlobalObject& global_object, double
// 3.5.5 IsValidISODate ( year, month, day ), https://tc39.es/proposal-temporal/#sec-temporal-isvalidisodate // 3.5.5 IsValidISODate ( year, month, day ), https://tc39.es/proposal-temporal/#sec-temporal-isvalidisodate
bool is_valid_iso_date(i32 year, u8 month, u8 day) bool is_valid_iso_date(i32 year, u8 month, u8 day)
{ {
// 1. Assert: year, month, and day are integers. // 1. If month < 1 or month > 12, then
// 2. If month < 1 or month > 12, then
if (month < 1 || month > 12) { if (month < 1 || month > 12) {
// a. Return false. // a. Return false.
return false; return false;
} }
// 3. Let daysInMonth be ! ISODaysInMonth(year, month). // 2. Let daysInMonth be ! ISODaysInMonth(year, month).
auto days_in_month = iso_days_in_month(year, month); auto days_in_month = iso_days_in_month(year, month);
// 4. If day < 1 or day > daysInMonth, then // 3. If day < 1 or day > daysInMonth, then
if (day < 1 || day > days_in_month) { if (day < 1 || day > days_in_month) {
// a. Return false. // a. Return false.
return false; return false;
} }
// 5. Return true. // 4. Return true.
return true; return true;
} }