RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 12:57:35 +00:00
Code Issues Activity Actions

ThemeEditor: Take drop events from the whole window

Browse source 
Drops were handled only by the Preview Widget previously. It probably
made a little more sense before the program redesign, as it took most of
window the space, but now honestly this idea doesn't hold up that well.
This commit is contained in:
Karol Kosek 2023-01-10 22:30:36 +01:00 • committed by Sam Atkins
parent 0267d35258
commit 93a2b2a02d
4 changed files with 34 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

31
Userland/Applications/ThemeEditor/MainWidget.cpp
View file

@ -646,4 +646,35 @@ ErrorOr<void> MainWidget::load_from_file(String const& filename, NonnullOwnPtr<C
return {}; return {};
} }
void MainWidget::drag_enter_event(GUI::DragEvent& event)
{
auto const& mime_types = event.mime_types();
if (mime_types.contains_slow("text/uri-list"))
event.accept();
}
void MainWidget::drop_event(GUI::DropEvent& event)
{
event.accept();
window()->move_to_front();
if (event.mime_data().has_urls()) {
auto urls = event.mime_data().urls();
if (urls.is_empty())
return;
if (urls.size() > 1) {
GUI::MessageBox::show(window(), "ThemeEditor can only open one file at a time!"sv, "One at a time please!"sv, GUI::MessageBox::Type::Error);
return;
}
auto response = FileSystemAccessClient::Client::the().try_request_file_deprecated(window(), urls.first().path(), Core::OpenMode::ReadOnly);
if (response.is_error())
return;
auto set_theme_from_file_result = m_preview_widget->set_theme_from_file(response.release_value());
if (set_theme_from_file_result.is_error())
GUI::MessageBox::show_error(window(), DeprecatedString::formatted("Setting theme from file has failed: {}", set_theme_from_file_result.error()));
}
}
} }

3
Userland/Applications/ThemeEditor/MainWidget.h
View file

@ -91,6 +91,9 @@ public:
private: private:
explicit MainWidget(NonnullRefPtr<AlignmentModel>); explicit MainWidget(NonnullRefPtr<AlignmentModel>);
virtual void drag_enter_event(GUI::DragEvent&) override;
virtual void drop_event(GUI::DropEvent&) override;
void save_to_file(String const& filename, NonnullOwnPtr<Core::Stream::File> file); void save_to_file(String const& filename, NonnullOwnPtr<Core::Stream::File> file);
ErrorOr<Core::AnonymousBuffer> encode(); ErrorOr<Core::AnonymousBuffer> encode();
void set_path(DeprecatedString); void set_path(DeprecatedString);

31
Userland/Applications/ThemeEditor/PreviewWidget.cpp
View file

@ -149,35 +149,4 @@ void PreviewWidget::resize_event(GUI::ResizeEvent&)
update_preview_window_locations(); update_preview_window_locations();
} }
void PreviewWidget::drag_enter_event(GUI::DragEvent& event)
{
auto const& mime_types = event.mime_types();
if (mime_types.contains_slow("text/uri-list"))
event.accept();
}
void PreviewWidget::drop_event(GUI::DropEvent& event)
{
event.accept();
window()->move_to_front();
if (event.mime_data().has_urls()) {
auto urls = event.mime_data().urls();
if (urls.is_empty())
return;
if (urls.size() > 1) {
GUI::MessageBox::show(window(), "ThemeEditor can only open one file at a time!"sv, "One at a time please!"sv, GUI::MessageBox::Type::Error);
return;
}
auto response = FileSystemAccessClient::Client::the().try_request_file_deprecated(window(), urls.first().path(), Core::OpenMode::ReadOnly);
if (response.is_error())
return;
auto set_theme_from_file_result = set_theme_from_file(response.release_value());
if (set_theme_from_file_result.is_error())
GUI::MessageBox::show_error(window(), DeprecatedString::formatted("Setting theme from file has failed: {}", set_theme_from_file_result.error()));
}
}
} }

2
Userland/Applications/ThemeEditor/PreviewWidget.h
View file

@ -38,8 +38,6 @@ private:
virtual void paint_preview(GUI::PaintEvent&) override; virtual void paint_preview(GUI::PaintEvent&) override;
virtual void second_paint_event(GUI::PaintEvent&) override; virtual void second_paint_event(GUI::PaintEvent&) override;
virtual void resize_event(GUI::ResizeEvent&) override; virtual void resize_event(GUI::ResizeEvent&) override;
virtual void drag_enter_event(GUI::DragEvent&) override;
virtual void drop_event(GUI::DropEvent&) override;
virtual void palette_changed() override; virtual void palette_changed() override;
void paint_hightlight_window(); void paint_hightlight_window();