RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:17:45 +00:00
Code Issues Activity Actions

Ladybird: Remove workaround for initial page load for WebDriver

Browse source 
The issue noted in the removed comment no longer seems to apply. The URL
loaded here is triggered before WebDriver even issues the POST /session
command.
This commit is contained in:
Timothy Flynn 2023-08-08 16:03:42 -04:00 • committed by Andreas Kling
parent 6c7422e8b7
commit 93ffa77370
1 changed files with 2 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Ladybird/Qt/BrowserWindow.cpp
View file

@ -495,12 +495,8 @@ Tab& BrowserWindow::new_tab(QString const& url, Web::HTML::ActivateTab activate_
tab_ptr->focus_location_editor();
// We *don't* load the initial page if we are connected to a WebDriver, as the Set URL command may come in very
// quickly, and become replaced by this load.
if (m_webdriver_content_ipc_path.is_empty()) {
// We make it HistoryNavigation so that the initial page doesn't get added to the history.
tab_ptr->navigate(url, Tab::LoadType::HistoryNavigation);
}
// We make it HistoryNavigation so that the initial page doesn't get added to the history.
tab_ptr->navigate(url, Tab::LoadType::HistoryNavigation);
return *tab_ptr;
}