RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-10 11:57:35 +00:00
Code Issues Activity Actions

LibJS: Compare Unicode locale variants using case-insensitive matching

Browse source 
In the IsStructurallyValidLanguageTag AO, we of course cannot assume the
variants are canonicalized to lower-case yet, because canonicalization
hasn't happened yet.
This commit is contained in:
Timothy Flynn 2021-09-01 18:54:30 -04:00 • committed by Linus Groh
parent fdedb3ab33
commit 940c023e09
2 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/Intl/AbstractOperations.cpp
View file

@ -26,7 +26,7 @@ static Optional<Unicode::LocaleID> is_structurally_valid_language_tag(StringView
quick_sort(variants); quick_sort(variants);
for (size_t i = 0; i < variants.size() - 1; ++i) { for (size_t i = 0; i < variants.size() - 1; ++i) {
if (variants[i] == variants[i + 1]) if (variants[i].equals_ignoring_case(variants[i + 1]))
return true; return true;
} }

7
Userland/Libraries/LibJS/Tests/builtins/Intl/Intl.getCanonicalLocales.js
View file

@ -18,6 +18,13 @@ describe("errors", () => {
}); });
test("duplicate variant subtags", () => { test("duplicate variant subtags", () => {
expect(() => {
Intl.getCanonicalLocales("en-posix-POSIX");
}).toThrowWithMessage(
RangeError,
"en-posix-POSIX is not a structurally valid language tag"
);
expect(() => { expect(() => {
Intl.getCanonicalLocales("en-POSIX-POSIX"); Intl.getCanonicalLocales("en-POSIX-POSIX");
}).toThrowWithMessage( }).toThrowWithMessage(