RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:17:35 +00:00
Code Issues Activity Actions

Userland: Port Model::column_name() to String

Browse source
This commit is contained in:
Karol Kosek 2023-05-14 19:02:08 +02:00 • committed by Andreas Kling
parent 741f07dedf
commit 945f05ed76
70 changed files with 218 additions and 222 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/DevTools/Profiler/DisassemblyModel.cpp
View file

@ -131,19 +131,19 @@ int DisassemblyModel::row_count(GUI::ModelIndex const&) const
return m_instructions.size();
}
DeprecatedString DisassemblyModel::column_name(int column) const
String DisassemblyModel::column_name(int column) const
{
switch (column) {
case Column::SampleCount:
return m_profile.show_percentages() ? "% Samples" : "# Samples";
return m_profile.show_percentages() ? "% Samples"_string.release_value_but_fixme_should_propagate_errors() : "# Samples"_string.release_value_but_fixme_should_propagate_errors();
case Column::Address:
return "Address";
return "Address"_short_string;
case Column::InstructionBytes:
return "Insn Bytes";
return "Insn Bytes"_string.release_value_but_fixme_should_propagate_errors();
case Column::Disassembly:
return "Disassembly";
return "Disassembly"_string.release_value_but_fixme_should_propagate_errors();
case Column::SourceLocation:
return "Source Location";
return "Source Location"_string.release_value_but_fixme_should_propagate_errors();
default:
VERIFY_NOT_REACHED();
return {};