RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-28 08:25:07 +00:00
Code Issues Activity Actions

Kernel: Suppress remaining unobserved KResult return codes

Browse source 
These are all cases where there is no clear and easy fix,
I've left FIXME bread crumbs so that these can hopefully
be fixed over time.
This commit is contained in:
Brian Gianforcaro 2020-08-05 02:13:30 -07:00 • committed by Andreas Kling
parent d67069d922
commit 946c96dd56
7 changed files with 23 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Kernel/FileSystem/Plan9FileSystem.cpp
View file

@ -636,7 +636,8 @@ Plan9FSInode::~Plan9FSInode()
{
Plan9FS::Message clunk_request { fs(), Plan9FS::Message::Type::Tclunk };
clunk_request << fid();
fs().post_message_and_explicitly_ignore_reply(clunk_request);
// FIXME: Should we observe this error somehow?
(void)fs().post_message_and_explicitly_ignore_reply(clunk_request);
}
KResult Plan9FSInode::ensure_open_for_mode(int mode)
@ -829,7 +830,8 @@ KResult Plan9FSInode::traverse_as_directory(Function<bool(const FS::DirectoryEnt
if (result.is_error()) {
Plan9FS::Message close_message { fs(), Plan9FS::Message::Type::Tclunk };
close_message << clone_fid;
fs().post_message_and_explicitly_ignore_reply(close_message);
// FIXME: Should we observe this error?
(void)fs().post_message_and_explicitly_ignore_reply(close_message);
return result;
}
}
@ -871,7 +873,8 @@ KResult Plan9FSInode::traverse_as_directory(Function<bool(const FS::DirectoryEnt
Plan9FS::Message close_message { fs(), Plan9FS::Message::Type::Tclunk };
close_message << clone_fid;
fs().post_message_and_explicitly_ignore_reply(close_message);
// FIXME: Should we observe this error?
(void)fs().post_message_and_explicitly_ignore_reply(close_message);
return result;
} else {
// TODO