RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:47:35 +00:00
Code Issues Activity Actions

Kernel: Suppress remaining unobserved KResult return codes

Browse source 
These are all cases where there is no clear and easy fix,
I've left FIXME bread crumbs so that these can hopefully
be fixed over time.
This commit is contained in:
Brian Gianforcaro 2020-08-05 02:13:30 -07:00 • committed by Andreas Kling
parent d67069d922
commit 946c96dd56
7 changed files with 23 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Kernel/TTY/TTY.cpp
View file

@ -55,9 +55,8 @@ void TTY::set_default_termios()
KResultOr<size_t> TTY::read(FileDescription&, size_t, u8* buffer, size_t size)
{
if (Process::current()->pgid() != pgid()) {
KResult result = Process::current()->send_signal(SIGTTIN, nullptr);
if (result.is_error())
return result;
// FIXME: Should we propigate this error path somehow?
(void)Process::current()->send_signal(SIGTTIN, nullptr);
return KResult(-EINTR);
}
@ -93,9 +92,8 @@ KResultOr<size_t> TTY::read(FileDescription&, size_t, u8* buffer, size_t size)
KResultOr<size_t> TTY::write(FileDescription&, size_t, const u8* buffer, size_t size)
{
if (Process::current()->pgid() != pgid()) {
KResult result = Process::current()->send_signal(SIGTTOU, nullptr);
if (result.is_error())
return result;
// FIXME: Should we propigate this error path somehow?
(void)Process::current()->send_signal(SIGTTOU, nullptr);
return KResult(-EINTR);
}
@ -255,7 +253,8 @@ void TTY::generate_signal(int signal)
InterruptDisabler disabler; // FIXME: Iterate over a set of process handles instead?
Process::for_each_in_pgrp(pgid(), [&](auto& process) {
dbg() << tty_name() << ": Send signal " << signal << " to " << process;
process.send_signal(signal, nullptr);
// FIXME: Should this error be propagated somehow?
(void)process.send_signal(signal, nullptr);
return IterationDecision::Continue;
});
}