RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 23:37:36 +00:00
Code Issues Activity Actions

LibJS: Implement Error.prototype.toString()

Browse source
This commit is contained in:
Linus Groh 2020-04-02 21:16:13 +01:00 • committed by Andreas Kling
parent 2636cac6e4
commit 94afcb54de
3 changed files with 39 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Libraries/LibJS/Runtime/ErrorPrototype.cpp
View file

@ -38,6 +38,7 @@ ErrorPrototype::ErrorPrototype()
{
put_native_property("name", name_getter, nullptr);
put_native_property("message", message_getter, nullptr);
put_native_function("toString", to_string);
}
ErrorPrototype::~ErrorPrototype()
@ -64,4 +65,27 @@ Value ErrorPrototype::message_getter(Interpreter& interpreter)
return js_string(interpreter.heap(), static_cast<const Error*>(this_object)->message());
}
Value ErrorPrototype::to_string(Interpreter& interpreter)
{
if (!interpreter.this_value().is_object())
return interpreter.throw_exception<Error>("TypeError", "Not an object");
auto& this_object = interpreter.this_value().as_object();
String name = "Error";
auto object_name_property = this_object.get("name");
if (object_name_property.has_value() && !object_name_property.value().is_undefined())
name = object_name_property.value().to_string();
String message = "";
auto object_message_property = this_object.get("message");
if (object_message_property.has_value() && !object_message_property.value().is_undefined())
message = object_message_property.value().to_string();
if (name.length() == 0)
return js_string(interpreter.heap(), message);
if (message.length() == 0)
return js_string(interpreter.heap(), name);
return js_string(interpreter.heap(), String::format("%s: %s", name.characters(), message.characters()));
}
}

2
Libraries/LibJS/Runtime/ErrorPrototype.h
View file

@ -38,6 +38,8 @@ public:
private:
virtual const char* class_name() const override { return "ErrorPrototype"; }
static Value to_string(Interpreter&);
static Value name_getter(Interpreter&);
static Value message_getter(Interpreter&);
};