RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:27:35 +00:00
Code Issues Activity Actions

LibJS/JIT: Add builtin for Math.sqrt()

Browse source
This commit is contained in:
Andreas Kling 2023-11-24 09:35:37 +01:00
parent 1d8a601f96
commit 94b634f029
4 changed files with 26 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibJS/Bytecode/Builtins.h
View file

@ -14,7 +14,8 @@ namespace JS::Bytecode {
// TitleCaseName, snake_case_name, base, property, argument_count // TitleCaseName, snake_case_name, base, property, argument_count
#define JS_ENUMERATE_BUILTINS(O) \ #define JS_ENUMERATE_BUILTINS(O) \
O(MathAbs, math_abs, Math, abs, 1) \ O(MathAbs, math_abs, Math, abs, 1) \
O(MathLog, math_log, Math, log, 1) O(MathLog, math_log, Math, log, 1) \
O(MathSqrt, math_sqrt, Math, sqrt, 1)
enum class Builtin { enum class Builtin {
#define DEFINE_BUILTIN_ENUM(name, ...) name, #define DEFINE_BUILTIN_ENUM(name, ...) name,

13
Userland/Libraries/LibJS/JIT/Compiler.cpp
View file

@ -2637,6 +2637,19 @@ void Compiler::compile_builtin_math_log(Assembler::Label&, Assembler::Label& end
m_assembler.jump(end); m_assembler.jump(end);
} }
static Value cxx_math_sqrt(VM& vm, Value, Value value)
{
return TRY_OR_SET_EXCEPTION(MathObject::sqrt_impl(vm, value));
}
void Compiler::compile_builtin_math_sqrt(Assembler::Label&, Assembler::Label& end)
{
native_call((void*)cxx_math_sqrt);
store_accumulator(RET);
check_exception();
m_assembler.jump(end);
}
void Compiler::compile_builtin_math_abs(Assembler::Label& slow_case, Assembler::Label& end) void Compiler::compile_builtin_math_abs(Assembler::Label& slow_case, Assembler::Label& end)
{ {
branch_if_int32(ARG2, [&] { branch_if_int32(ARG2, [&] {

14
Userland/Libraries/LibJS/Runtime/MathObject.cpp
View file

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org> * Copyright (c) 2020-2023, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2020-2023, Linus Groh <linusg@serenityos.org> * Copyright (c) 2020-2023, Linus Groh <linusg@serenityos.org>
* Copyright (c) 2021, Idan Horowitz <idan.horowitz@serenityos.org> * Copyright (c) 2021, Idan Horowitz <idan.horowitz@serenityos.org>
* Copyright (c) 2023, Shannon Booth <shannon@serenityos.org> * Copyright (c) 2023, Shannon Booth <shannon@serenityos.org>
@ -31,7 +31,7 @@ void MathObject::initialize(Realm& realm)
u8 attr = Attribute::Writable | Attribute::Configurable; u8 attr = Attribute::Writable | Attribute::Configurable;
define_native_function(realm, vm.names.abs, abs, 1, attr, Bytecode::Builtin::MathAbs); define_native_function(realm, vm.names.abs, abs, 1, attr, Bytecode::Builtin::MathAbs);
define_native_function(realm, vm.names.random, random, 0, attr); define_native_function(realm, vm.names.random, random, 0, attr);
define_native_function(realm, vm.names.sqrt, sqrt, 1, attr); define_native_function(realm, vm.names.sqrt, sqrt, 1, attr, Bytecode::Builtin::MathSqrt);
define_native_function(realm, vm.names.floor, floor, 1, attr); define_native_function(realm, vm.names.floor, floor, 1, attr);
define_native_function(realm, vm.names.ceil, ceil, 1, attr); define_native_function(realm, vm.names.ceil, ceil, 1, attr);
define_native_function(realm, vm.names.round, round, 1, attr); define_native_function(realm, vm.names.round, round, 1, attr);
@ -821,10 +821,10 @@ JS_DEFINE_NATIVE_FUNCTION(MathObject::sinh)
} }
// 21.3.2.32 Math.sqrt ( x ), https://tc39.es/ecma262/#sec-math.sqrt // 21.3.2.32 Math.sqrt ( x ), https://tc39.es/ecma262/#sec-math.sqrt
JS_DEFINE_NATIVE_FUNCTION(MathObject::sqrt) ThrowCompletionOr<Value> MathObject::sqrt_impl(VM& vm, Value x)
{ {
// Let n be ? ToNumber(x). // Let n be ? ToNumber(x).
auto number = TRY(vm.argument(0).to_number(vm)); auto number = TRY(x.to_number(vm));
// 2. If n is one of NaN, +0𝔽, -0𝔽, or +∞𝔽, return n. // 2. If n is one of NaN, +0𝔽, -0𝔽, or +∞𝔽, return n.
if (number.is_nan() || number.as_double() == 0 || number.is_positive_infinity()) if (number.is_nan() || number.as_double() == 0 || number.is_positive_infinity())
@ -838,6 +838,12 @@ JS_DEFINE_NATIVE_FUNCTION(MathObject::sqrt)
return Value(::sqrt(number.as_double())); return Value(::sqrt(number.as_double()));
} }
// 21.3.2.32 Math.sqrt ( x ), https://tc39.es/ecma262/#sec-math.sqrt
JS_DEFINE_NATIVE_FUNCTION(MathObject::sqrt)
{
return sqrt_impl(vm, vm.argument(0));
}
// 21.3.2.33 Math.tan ( x ), https://tc39.es/ecma262/#sec-math.tan // 21.3.2.33 Math.tan ( x ), https://tc39.es/ecma262/#sec-math.tan
JS_DEFINE_NATIVE_FUNCTION(MathObject::tan) JS_DEFINE_NATIVE_FUNCTION(MathObject::tan)
{ {

1
Userland/Libraries/LibJS/Runtime/MathObject.h
View file

@ -19,6 +19,7 @@ public:
virtual ~MathObject() override = default; virtual ~MathObject() override = default;
static ThrowCompletionOr<Value> log_impl(VM&, Value); static ThrowCompletionOr<Value> log_impl(VM&, Value);
static ThrowCompletionOr<Value> sqrt_impl(VM&, Value);
private: private:
explicit MathObject(Realm&); explicit MathObject(Realm&);