From 95238bdb1650740dfb530091fd5cd0d195f17e68 Mon Sep 17 00:00:00 2001 From: Liav A Date: Fri, 15 Jul 2022 11:10:46 +0300 Subject: [PATCH] Kernel/Storage: Check IDE error condition under the correct lock This bug was probably around for a very long time, but it is noticeable only under VirtualBox as it generated an non fatal error which caused a kernel panic because we VERIFYed the wrong lock to be locked. --- Kernel/Storage/ATA/IDEChannel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Kernel/Storage/ATA/IDEChannel.cpp b/Kernel/Storage/ATA/IDEChannel.cpp index e2889f68be..27716a6317 100644 --- a/Kernel/Storage/ATA/IDEChannel.cpp +++ b/Kernel/Storage/ATA/IDEChannel.cpp @@ -159,7 +159,7 @@ static void print_ide_status(u8 status) void IDEChannel::try_disambiguate_error() { - VERIFY(m_lock.is_locked()); + VERIFY(m_request_lock.is_locked()); dbgln("IDEChannel: Error cause:"); switch (m_device_error) {