From 9547a8e8a291b7b3f7a633fe835be8031f4f6d5d Mon Sep 17 00:00:00 2001 From: Idan Horowitz Date: Sat, 9 Apr 2022 22:49:20 +0300 Subject: [PATCH] Kernel: Remove big lock from sys$close This syscall doesn't access any unprotected shared data. --- Kernel/API/Syscall.h | 2 +- Kernel/Syscalls/open.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Kernel/API/Syscall.h b/Kernel/API/Syscall.h index 083ae84b52..45cc3ed771 100644 --- a/Kernel/API/Syscall.h +++ b/Kernel/API/Syscall.h @@ -54,7 +54,7 @@ enum class NeedsBigProcessLock { S(clock_gettime, NeedsBigProcessLock::No) \ S(clock_nanosleep, NeedsBigProcessLock::No) \ S(clock_settime, NeedsBigProcessLock::No) \ - S(close, NeedsBigProcessLock::Yes) \ + S(close, NeedsBigProcessLock::No) \ S(connect, NeedsBigProcessLock::Yes) \ S(create_inode_watcher, NeedsBigProcessLock::Yes) \ S(create_thread, NeedsBigProcessLock::Yes) \ diff --git a/Kernel/Syscalls/open.cpp b/Kernel/Syscalls/open.cpp index 46f654753c..941722ba85 100644 --- a/Kernel/Syscalls/open.cpp +++ b/Kernel/Syscalls/open.cpp @@ -69,7 +69,7 @@ ErrorOr Process::sys$open(Userspace use ErrorOr Process::sys$close(int fd) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) + VERIFY_NO_PROCESS_BIG_LOCK(this) TRY(require_promise(Pledge::stdio)); auto description = TRY(open_file_description(fd)); auto result = description->close();