RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:37:35 +00:00
Code Issues Activity Actions

LibWeb: Only create iframe nested context if iframe document has context

Browse source 
We had glossed over a condition in the spec that said we should only run
the nested context creation steps when the iframe's own containing
document has a browsing context.
This commit is contained in:
Andreas Kling 2022-09-19 12:33:05 +02:00
parent 8ead228202
commit 954da8fde5
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.cpp
View file

@ -38,16 +38,16 @@ void HTMLIFrameElement::inserted()
{ {
HTMLElement::inserted(); HTMLElement::inserted();
if (!is_connected()) // When an iframe element element is inserted into a document whose browsing context is non-null, the user agent must run these steps:
return; if (document().browsing_context()) {
// 1. Create a new nested browsing context for element.
create_new_nested_browsing_context();
// 1. Create a new nested browsing context for element. // FIXME: 2. If element has a sandbox attribute, then parse the sandboxing directive given the attribute's value and element's iframe sandboxing flag set.
create_new_nested_browsing_context();
// FIXME: 2. If element has a sandbox attribute, then parse the sandboxing directive given the attribute's value and element's iframe sandboxing flag set. // 3. Process the iframe attributes for element, with initialInsertion set to true.
load_src(attribute(HTML::AttributeNames::src));
// 3. Process the iframe attributes for element, with initialInsertion set to true. }
load_src(attribute(HTML::AttributeNames::src));
} }
// https://html.spec.whatwg.org/multipage/iframe-embed-object.html#the-iframe-element:the-iframe-element-7 // https://html.spec.whatwg.org/multipage/iframe-embed-object.html#the-iframe-element:the-iframe-element-7