RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:27:35 +00:00
Code Issues Activity Actions

LibJS: Remove unnecessary value_or() from get()

Browse source 
Object::get() never returns an empty value anymore, as per the spec, so
having a value_or() fallback is no longer needed.
This commit is contained in:
Linus Groh 2021-07-04 22:55:45 +01:00 • committed by Andreas Kling
parent 57f7e6e775
commit 9555ca99a0
19 changed files with 56 additions and 56 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/IteratorOperations.cpp
View file

@ -74,7 +74,7 @@ Object* iterator_next(Object& iterator, Value value)
bool iterator_complete(GlobalObject& global_object, Object& iterator_result)
{
auto& vm = global_object.vm();
auto done = iterator_result.get(vm.names.done).value_or(js_undefined());
auto done = iterator_result.get(vm.names.done);
if (vm.exception())
return {};
return done.to_boolean();
@ -84,7 +84,7 @@ bool iterator_complete(GlobalObject& global_object, Object& iterator_result)
Value iterator_value(GlobalObject& global_object, Object& iterator_result)
{
auto& vm = global_object.vm();
auto value = iterator_result.get(vm.names.value).value_or(js_undefined());
auto value = iterator_result.get(vm.names.value);
if (vm.exception())
return {};
return value;