RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-29 15:55:07 +00:00
Code Issues Activity Actions

LibWeb: Avoid infinite recursion when hit testing SVGs

Browse source 
Previously, step 5 of the stacking context hit testing would just call
`hit_test()` on the stacking context's paintable box. Which (at least
for SVGs) is just indirect infinite recursion (it'll end up right back
where it started after going through a few functions).

This now explicitly hit tests the descendants, which seems more correct,
and avoids the crash for SVGs, but nothing really seems to depend on
this step. Another solution (which I've done for a while working on
SVGs) is just to delete step 5 entirely, and nothing seems to break.

Fixes #22305
This commit is contained in:
MacDue 2024-02-17 18:53:32 +00:00 • committed by Alexander Kalenik
parent dde11e1757
commit 957c20b676
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/Painting/StackingContext.cpp
View file

@ -425,8 +425,12 @@ TraversalDecision StackingContext::hit_test(CSSPixelPoint position, HitTestType
// 5. the in-flow, inline-level, non-positioned descendants, including inline tables and inline blocks. // 5. the in-flow, inline-level, non-positioned descendants, including inline tables and inline blocks.
if (paintable().layout_node().children_are_inline() && is<Layout::BlockContainer>(paintable().layout_node())) { if (paintable().layout_node().children_are_inline() && is<Layout::BlockContainer>(paintable().layout_node())) {
if (paintable_box().hit_test(transformed_position, type, callback) == TraversalDecision::Break) for (auto const* child = paintable().last_child(); child; child = child->previous_sibling()) {
return TraversalDecision::Break; if (child->is_inline() && !child->is_absolutely_positioned() && !child->stacking_context()) {
if (child->hit_test(transformed_position, type, callback) == TraversalDecision::Break)
return TraversalDecision::Break;
}
}
} }
// 4. the non-positioned floats. // 4. the non-positioned floats.