mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 09:07:45 +00:00
LibJS: Throw InternalErrors instead of Errors on CallStackSizeExceeded
These seem more appropriate.
This commit is contained in:
parent
7341faceeb
commit
957f54d96f
6 changed files with 9 additions and 9 deletions
|
@ -1517,7 +1517,7 @@ static ThrowCompletionOr<size_t> flatten_into_array(GlobalObject& global_object,
|
|||
|
||||
if (depth > 0 && TRY(value.is_array(global_object))) {
|
||||
if (vm.did_reach_stack_space_limit())
|
||||
return vm.throw_completion<Error>(global_object, ErrorType::CallStackSizeExceeded);
|
||||
return vm.throw_completion<InternalError>(global_object, ErrorType::CallStackSizeExceeded);
|
||||
|
||||
auto length = TRY(length_of_array_like(global_object, value.as_object()));
|
||||
target_index = TRY(flatten_into_array(global_object, new_array, value.as_object(), length, target_index, depth - 1));
|
||||
|
|
|
@ -487,7 +487,7 @@ ThrowCompletionOr<Value> ProxyObject::internal_get(PropertyKey const& property_n
|
|||
//
|
||||
// In JS code: `h = {}; p = new Proxy({}, h); h.__proto__ = p; p.foo // or h.foo`
|
||||
if (vm.did_reach_stack_space_limit())
|
||||
return vm.throw_completion<Error>(global_object, ErrorType::CallStackSizeExceeded);
|
||||
return vm.throw_completion<InternalError>(global_object, ErrorType::CallStackSizeExceeded);
|
||||
|
||||
// 6. Let trap be ? GetMethod(handler, "get").
|
||||
auto trap = TRY(Value(&m_handler).get_method(global_object, vm.names.get));
|
||||
|
|
|
@ -103,7 +103,7 @@ public:
|
|||
VERIFY(!exception());
|
||||
// Ensure we got some stack space left, so the next function call doesn't kill us.
|
||||
if (did_reach_stack_space_limit())
|
||||
return throw_completion<Error>(global_object, ErrorType::CallStackSizeExceeded);
|
||||
return throw_completion<InternalError>(global_object, ErrorType::CallStackSizeExceeded);
|
||||
m_execution_context_stack.append(&context);
|
||||
return {};
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue