mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 22:07:35 +00:00
LibJS: Set Token's m_offset to the value's start index
This makes much more sense than the current way of setting it to the Lexer's m_position after consuming the full value.
This commit is contained in:
parent
c1d3b557d5
commit
95a9f12b97
2 changed files with 9 additions and 4 deletions
|
@ -2138,7 +2138,12 @@ RefPtr<BindingPattern> Parser::synthesize_binding_pattern(Expression const& expr
|
|||
return error.position.has_value() && range.contains(*error.position);
|
||||
});
|
||||
// Make a parser and parse the source for this expression as a binding pattern.
|
||||
auto source = m_state.lexer.source().substring_view(expression.source_range().start.offset - 2, expression.source_range().end.offset - expression.source_range().start.offset);
|
||||
// NOTE: There's currently a fundamental problem that we pass the *next* (a.k.a. `current_token`)
|
||||
// token's position to most nodes' SourceRange when using `rule_start.position(), position()`.
|
||||
// This means that `source` will contain the subsequent token's trivia, if any (which is fine).
|
||||
auto source_start_offset = expression.source_range().start.offset;
|
||||
auto source_end_offset = expression.source_range().end.offset;
|
||||
auto source = m_state.lexer.source().substring_view(source_start_offset, source_end_offset - source_start_offset);
|
||||
Lexer lexer { source, m_state.lexer.filename(), expression.source_range().start.line, expression.source_range().start.column };
|
||||
Parser parser { lexer };
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue