From 95aacd4f78d14c3f4ef76227506181250e8c430a Mon Sep 17 00:00:00 2001 From: MacDue Date: Wed, 25 Jan 2023 19:11:00 +0100 Subject: [PATCH] LibWeb: Remove some unchecked .value() calls in StyleValue Here .to_string() was being called, which gives an ErrorOr, then .value() was called on that without any checks. Cases like this should at least be .release_value_but_fixme_should_propagate_errors() which makes it clear the error is ignored, but here it's easy to propagate. --- Userland/Libraries/LibWeb/CSS/StyleValue.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Userland/Libraries/LibWeb/CSS/StyleValue.cpp b/Userland/Libraries/LibWeb/CSS/StyleValue.cpp index ae22e9574c..c8a466b7db 100644 --- a/Userland/Libraries/LibWeb/CSS/StyleValue.cpp +++ b/Userland/Libraries/LibWeb/CSS/StyleValue.cpp @@ -1437,13 +1437,13 @@ ErrorOr GridAreaShorthandStyleValue::to_string() const { StringBuilder builder; if (!m_row_start->as_grid_track_placement().grid_track_placement().is_auto()) - builder.appendff("{}", m_row_start->as_grid_track_placement().grid_track_placement().to_string().value()); + TRY(builder.try_appendff("{}", TRY(m_row_start->as_grid_track_placement().grid_track_placement().to_string()))); if (!m_column_start->as_grid_track_placement().grid_track_placement().is_auto()) - builder.appendff(" / {}", m_column_start->as_grid_track_placement().grid_track_placement().to_string().value()); + TRY(builder.try_appendff(" / {}", TRY(m_column_start->as_grid_track_placement().grid_track_placement().to_string()))); if (!m_row_end->as_grid_track_placement().grid_track_placement().is_auto()) - builder.appendff(" / {}", m_row_end->as_grid_track_placement().grid_track_placement().to_string().value()); + TRY(builder.try_appendff(" / {}", TRY(m_row_end->as_grid_track_placement().grid_track_placement().to_string()))); if (!m_column_end->as_grid_track_placement().grid_track_placement().is_auto()) - builder.appendff(" / {}", m_column_end->as_grid_track_placement().grid_track_placement().to_string().value()); + TRY(builder.try_appendff(" / {}", TRY(m_column_end->as_grid_track_placement().grid_track_placement().to_string()))); return builder.to_string(); }