RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 05:48:12 +00:00
Code Issues Activity Actions

LibJS/Bytecode: Support private identifiers in optional chaining

Browse source 
Fixes 4 test262 tests :^)
This commit is contained in:
Luke Wilde 2023-06-23 19:09:41 +01:00 • committed by Andreas Kling
parent fc45831fb3
commit 95d619943e
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp
View file

@ -2698,11 +2698,11 @@ static Bytecode::CodeGenerationErrorOr<void> generate_optional_chain(Bytecode::G
generator.emit<Bytecode::Op::Store>(current_value_register);
return {};
},
[&](OptionalChain::PrivateMemberReference const&) -> Bytecode::CodeGenerationErrorOr<void> {
return Bytecode::CodeGenerationError {
&optional_chain,
"Unimplemented reference: PrivateMemberReference"sv,
};
[&](OptionalChain::PrivateMemberReference const& ref) -> Bytecode::CodeGenerationErrorOr<void> {
generator.emit<Bytecode::Op::Store>(current_base_register);
generator.emit<Bytecode::Op::GetPrivateById>(generator.intern_identifier(ref.private_identifier->string()));
generator.emit<Bytecode::Op::Store>(current_value_register);
return {};
}));
}