RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:57:47 +00:00
Code Issues Activity Actions

Ladybird: Add Favicon to the window

Browse source
This commit is contained in:
Keir Davis 2022-07-05 05:53:11 +01:00 • committed by Andrew Kaster
parent 47d7f1efec
commit 95e3e06a1e
4 changed files with 14 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Ladybird/BrowserWindow.cpp
View file

@ -19,6 +19,7 @@ BrowserWindow::BrowserWindow()
QObject::connect(m_view, &WebView::loadStarted, m_location_edit, &QLineEdit::setText); QObject::connect(m_view, &WebView::loadStarted, m_location_edit, &QLineEdit::setText);
QObject::connect(m_location_edit, &QLineEdit::returnPressed, this, &BrowserWindow::location_edit_return_pressed); QObject::connect(m_location_edit, &QLineEdit::returnPressed, this, &BrowserWindow::location_edit_return_pressed);
QObject::connect(m_view, &WebView::title_changed, this, &BrowserWindow::page_title_changed); QObject::connect(m_view, &WebView::title_changed, this, &BrowserWindow::page_title_changed);
QObject::connect(m_view, &WebView::favicon_changed, this, &BrowserWindow::page_favicon_changed);
} }
void BrowserWindow::location_edit_return_pressed() void BrowserWindow::location_edit_return_pressed()
@ -33,3 +34,8 @@ void BrowserWindow::page_title_changed(QString title)
else else
setWindowTitle(QString("%1 - Ladybird").arg(title)); setWindowTitle(QString("%1 - Ladybird").arg(title));
} }
void BrowserWindow::page_favicon_changed(QIcon icon)
{
setWindowIcon(icon);
}

2
Ladybird/BrowserWindow.h
View file

@ -1,3 +1,4 @@
#include <QIcon>
#include <QLineEdit> #include <QLineEdit>
#include <QMainWindow> #include <QMainWindow>
#include <QToolBar> #include <QToolBar>
@ -16,6 +17,7 @@ public:
public slots: public slots:
void location_edit_return_pressed(); void location_edit_return_pressed();
void page_title_changed(QString); void page_title_changed(QString);
void page_favicon_changed(QIcon);
private: private:
QToolBar* m_toolbar { nullptr }; QToolBar* m_toolbar { nullptr };

6
Ladybird/WebView.cpp
View file

@ -48,6 +48,7 @@
#include <LibWebSocket/ConnectionInfo.h> #include <LibWebSocket/ConnectionInfo.h>
#include <LibWebSocket/Message.h> #include <LibWebSocket/Message.h>
#include <LibWebSocket/WebSocket.h> #include <LibWebSocket/WebSocket.h>
#include <QIcon>
#include <QMouseEvent> #include <QMouseEvent>
#include <QPaintEvent> #include <QPaintEvent>
#include <QPainter> #include <QPainter>
@ -210,8 +211,11 @@ public:
m_view.viewport()->update(); m_view.viewport()->update();
} }
virtual void page_did_change_favicon(Gfx::Bitmap const&) override virtual void page_did_change_favicon(Gfx::Bitmap const& bitmap) override
{ {
ByteBuffer bytebuffer = bitmap.serialize_to_byte_buffer();
QPixmap icon = QPixmap::fromImage(QImage(bytebuffer.bytes().data(), bitmap.width(), bitmap.height(), QImage::Format_ARGB32));
emit m_view.favicon_changed(QIcon(icon));
} }
virtual void page_did_layout() override virtual void page_did_layout() override

1
Ladybird/WebView.h
View file

@ -34,6 +34,7 @@ signals:
void linkUnhovered(); void linkUnhovered();
void loadStarted(QString); void loadStarted(QString);
void title_changed(QString); void title_changed(QString);
void favicon_changed(QIcon);
private: private:
Gfx::IntPoint to_content(Gfx::IntPoint) const; Gfx::IntPoint to_content(Gfx::IntPoint) const;