RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 10:47:35 +00:00
Code Issues Activity Actions

LibCore: Remove awkward EventLoop::wake_once() API

Browse source 
This was used in exactly one place, to avoid sending multiple
CustomEvents to the enqueuer thread in Audio::ConnectionToServer.

Instead of this, we now just send a CustomEvent and wake the enqueuer
thread. If it wakes up and has multiple CustomEvents, they get delivered
and ignored in no time anyway. Since they only get ignored if there's
no work to be done, this seems harmless.
This commit is contained in:
Andreas Kling 2023-04-23 18:20:38 +02:00
parent 896d1e4f42
commit 9601b516b8
3 changed files with 7 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibCore/EventLoop.h
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2018-2023, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, kleines Filmröllchen <filmroellchen@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
@ -55,11 +55,6 @@ public:
Yes,
};
enum class ShouldWake {
No,
Yes
};
enum class WaitMode {
WaitForEvents,
PollForEvents,
@ -82,9 +77,8 @@ public:
// Pump the event loop until some condition is met.
void spin_until(Function<bool()>);
// Post an event to this event loop and possibly wake the loop.
void post_event(Object& receiver, NonnullOwnPtr<Event>&&, ShouldWake = ShouldWake::No);
void wake_once(Object& receiver, int custom_event_type);
// Post an event to this event loop.
void post_event(Object& receiver, NonnullOwnPtr<Event>&&);
void add_job(NonnullRefPtr<Promise<NonnullRefPtr<Object>>> job_promise);