RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 08:17:35 +00:00
Code Issues Activity Actions

LibWebView+Ladybird: Remove duplicate WebContent callback

Browse source 
We have on_navigate_back + on_back_button and on_navigate_forward +
on_forward_button. Remove the *_button variants.
This commit is contained in:
Timothy Flynn 2023-08-18 18:33:25 -04:00 • committed by Andreas Kling
parent 1adf06c9f0
commit 9608bfb576
5 changed files with 14 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWebView/OutOfProcessWebView.cpp
View file

@ -134,11 +134,11 @@ void OutOfProcessWebView::mouseup_event(GUI::MouseEvent& event)
enqueue_input_event(event);
if (event.button() == GUI::MouseButton::Backward) {
if (on_back_button)
on_back_button();
if (on_navigate_back)
on_navigate_back();
} else if (event.button() == GUI::MouseButton::Forward) {
if (on_forward_button)
on_forward_button();
if (on_navigate_forward)
on_navigate_forward();
}
}

2
Userland/Libraries/LibWebView/ViewImplementation.h
View file

@ -122,8 +122,6 @@ public:
Function<Gfx::IntRect()> on_maximize_window;
Function<Gfx::IntRect()> on_minimize_window;
Function<Gfx::IntRect()> on_fullscreen_window;
Function<void()> on_back_button;
Function<void()> on_forward_button;
virtual void notify_server_did_layout(Badge<WebContentClient>, Gfx::IntSize content_size) = 0;
virtual void notify_server_did_paint(Badge<WebContentClient>, i32 bitmap_id, Gfx::IntSize) = 0;