mirror of
https://github.com/RGBCube/serenity
synced 2025-07-26 01:07:35 +00:00
More moving towards using signed types.
I'm still feeling this out, but I am starting to like the general idea.
This commit is contained in:
parent
beda478821
commit
9624b54703
48 changed files with 234 additions and 250 deletions
|
@ -138,7 +138,7 @@ void DirectoryView::paint_event(GPaintEvent&)
|
|||
int painted_item_index = 0;
|
||||
|
||||
auto process_entries = [&] (const Vector<Entry>& entries) {
|
||||
for (size_t i = 0; i < entries.size(); ++i, ++painted_item_index) {
|
||||
for (int i = 0; i < entries.size(); ++i, ++painted_item_index) {
|
||||
auto& entry = entries[i];
|
||||
int y = painted_item_index * item_height();
|
||||
Rect icon_rect(horizontal_padding, y, icon_size, item_height());
|
||||
|
|
|
@ -37,7 +37,7 @@ private:
|
|||
bool is_directory() const { return S_ISDIR(mode); }
|
||||
};
|
||||
|
||||
const Entry& entry(size_t index) const
|
||||
const Entry& entry(int index) const
|
||||
{
|
||||
if (index < m_directories.size())
|
||||
return m_directories[index];
|
||||
|
|
|
@ -227,8 +227,8 @@ void GlyphEditorWidget::draw_at_mouse(const GMouseEvent& event)
|
|||
int x = (event.x() - 1) / m_scale;
|
||||
int y = (event.y() - 1) / m_scale;
|
||||
auto bitmap = font().glyph_bitmap(m_glyph);
|
||||
ASSERT((unsigned)x < bitmap.width());
|
||||
ASSERT((unsigned)y < bitmap.height());
|
||||
ASSERT(x < bitmap.width());
|
||||
ASSERT(y < bitmap.height());
|
||||
if (bitmap.bit_at(x, y) == set)
|
||||
return;
|
||||
bitmap.set_bit_at(x, y, set);
|
||||
|
|
|
@ -84,7 +84,7 @@ void Terminal::Line::clear(Attribute attribute)
|
|||
|
||||
Terminal::~Terminal()
|
||||
{
|
||||
for (size_t i = 0; i < m_rows; ++i)
|
||||
for (int i = 0; i < m_rows; ++i)
|
||||
delete m_lines[i];
|
||||
delete [] m_lines;
|
||||
free(m_horizontal_tabs);
|
||||
|
@ -115,7 +115,7 @@ inline bool is_valid_final_character(byte ch)
|
|||
unsigned parse_uint(const String& str, bool& ok)
|
||||
{
|
||||
unsigned value = 0;
|
||||
for (size_t i = 0; i < str.length(); ++i) {
|
||||
for (int i = 0; i < str.length(); ++i) {
|
||||
if (str[i] < '0' || str[i] > '9') {
|
||||
ok = false;
|
||||
return 0;
|
||||
|
@ -552,7 +552,7 @@ void Terminal::on_char(byte ch)
|
|||
|
||||
void Terminal::inject_string(const String& str)
|
||||
{
|
||||
for (size_t i = 0; i < str.length(); ++i)
|
||||
for (int i = 0; i < str.length(); ++i)
|
||||
on_char(str[i]);
|
||||
}
|
||||
|
||||
|
@ -562,12 +562,12 @@ void Terminal::unimplemented_escape()
|
|||
builder.appendf("((Unimplemented escape: %c", m_final);
|
||||
if (!m_parameters.is_empty()) {
|
||||
builder.append(" parameters:");
|
||||
for (size_t i = 0; i < m_parameters.size(); ++i)
|
||||
for (int i = 0; i < m_parameters.size(); ++i)
|
||||
builder.append((char)m_parameters[i]);
|
||||
}
|
||||
if (!m_intermediates.is_empty()) {
|
||||
builder.append(" intermediates:");
|
||||
for (size_t i = 0; i < m_intermediates.size(); ++i)
|
||||
for (int i = 0; i < m_intermediates.size(); ++i)
|
||||
builder.append((char)m_intermediates[i]);
|
||||
}
|
||||
builder.append("))");
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue