RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:57:45 +00:00
Code Issues Activity Actions

LibAudio: Speed up WavWriter by buffering output data

Browse source 
We were calling write syscall twice for every sample, which effectively
hurt the writer's performance.

With this change exporting a melody in the Piano app now takes less than
a second, which previously took about 20 seconds on my machine.

Additionally, I've removed an unused `WavWriter::file()` getter.
This commit is contained in:
Karol Kosek 2023-11-23 22:09:13 +01:00 • committed by Tim Flynn
parent fbf87299a2
commit 963a6b3d3d
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibAudio/WavWriter.cpp
View file

@ -33,7 +33,8 @@ WavWriter::~WavWriter()
ErrorOr<void> WavWriter::set_file(StringView path)
{
m_file = TRY(Core::File::open(path, Core::File::OpenMode::Write));
auto file = TRY(Core::File::open(path, Core::File::OpenMode::Write));
m_file = TRY(Core::OutputBufferedFile::create(move(file)));
TRY(m_file->seek(44, SeekMode::SetPosition));
m_finalized = false;
return {};