RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:27:45 +00:00
Code Issues Activity Actions

LibGUI: Fixes modified indicator behavior after saving

Browse source 
Pior to this change when the user added text after having saved the file
the Text Editor wouldn't enable the modified flag, unless this new text
was a new line.

This happened because the UndoStack was merging the Command added by
the new text with the old text one, and when is_current_modified()
was called, the m_stack_index would not have been incremented, and
it would return false.

In this change was added a condition to verify if the modified tag is
active, and the merge is only done if the document is already modified.
This commit is contained in:
luiz 2021-08-14 20:03:37 -03:00 • committed by Andreas Kling
parent 83c412ee9e
commit 964249a5b0
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGUI/UndoStack.cpp
View file

@ -62,7 +62,7 @@ void UndoStack::push(NonnullOwnPtr<Command> command)
if (m_clean_index.has_value() && m_clean_index.value() > m_stack.size())
m_clean_index = {};
if (!m_stack.is_empty()) {
if (!m_stack.is_empty() && is_current_modified()) {
if (m_stack.last().merge_with(*command))
return;
}