From 96459e4b3a6f82118fd40867de4dfe7761baa219 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Mon, 21 Feb 2022 10:15:51 -0500 Subject: [PATCH] LibJS: Define the Intl.Collator's compare function name to be empty --- .../Libraries/LibJS/Runtime/Intl/CollatorCompareFunction.cpp | 1 + .../builtins/Intl/Collator/Collator.prototype.compare.js | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/Userland/Libraries/LibJS/Runtime/Intl/CollatorCompareFunction.cpp b/Userland/Libraries/LibJS/Runtime/Intl/CollatorCompareFunction.cpp index 6c8240470d..5abbab99db 100644 --- a/Userland/Libraries/LibJS/Runtime/Intl/CollatorCompareFunction.cpp +++ b/Userland/Libraries/LibJS/Runtime/Intl/CollatorCompareFunction.cpp @@ -26,6 +26,7 @@ void CollatorCompareFunction::initialize(GlobalObject& global_object) { auto& vm = global_object.vm(); define_direct_property(vm.names.length, Value(2), Attribute::Configurable); + define_direct_property(vm.names.name, js_string(vm, String::empty()), Attribute::Configurable); } // 10.3.3.2 CompareStrings ( collator, x, y ), https://tc39.es/ecma402/#sec-collator-comparestrings diff --git a/Userland/Libraries/LibJS/Tests/builtins/Intl/Collator/Collator.prototype.compare.js b/Userland/Libraries/LibJS/Tests/builtins/Intl/Collator/Collator.prototype.compare.js index f98ff8b0ce..ec27f2a2fb 100644 --- a/Userland/Libraries/LibJS/Tests/builtins/Intl/Collator/Collator.prototype.compare.js +++ b/Userland/Libraries/LibJS/Tests/builtins/Intl/Collator/Collator.prototype.compare.js @@ -3,6 +3,10 @@ describe("correct behavior", () => { expect(new Intl.Collator().compare).toHaveLength(2); }); + test("name is empty string", () => { + expect(new Intl.Collator().compare.name).toBe(""); + }); + test("basic functionality", () => { const collator = new Intl.Collator(); expect(collator.compare("", "")).toBe(0);