RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:27:43 +00:00
Code Issues Activity Actions

LibWeb: Reject improperly encoded XML documents as not well-formed

Browse source
This commit is contained in:
Idan Horowitz 2023-11-17 15:14:07 +02:00 • committed by Andreas Kling
parent 278e8afb42
commit 9677d8eeac
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibWeb/DOM/DocumentLoading.cpp
View file

@ -159,6 +159,9 @@ bool build_xml_document(DOM::Document& document, ByteBuffer const& data, Optiona
decoder = TextCodec::decoder_for(encoding); decoder = TextCodec::decoder_for(encoding);
} }
VERIFY(decoder.has_value()); VERIFY(decoder.has_value());
// Well-formed XML documents contain only properly encoded characters
if (!decoder->validate(data))
return false;
auto source = decoder->to_utf8(data).release_value_but_fixme_should_propagate_errors(); auto source = decoder->to_utf8(data).release_value_but_fixme_should_propagate_errors();
XML::Parser parser(source, { .resolve_external_resource = resolve_xml_resource }); XML::Parser parser(source, { .resolve_external_resource = resolve_xml_resource });
XMLDocumentBuilder builder { document }; XMLDocumentBuilder builder { document };