RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 04:48:14 +00:00
Code Issues Activity Actions

LibGUI: Make a new connection to NotificationServer each time

Browse source 
Since NotificationServer is a spawn-on-demand + die-when-not-used type
of service, we can't expect a singleton connection to it to remain open
and useful.

We solve this for now by making a new IPC connection for every new
notification sent. Maybe there's a better solution for this.
This commit is contained in:
Andreas Kling 2020-03-26 20:10:03 +01:00
parent bc7a9097a7
commit 96c7e2cd6d
1 changed files with 2 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Libraries/LibGUI/Notification.cpp
View file

@ -32,17 +32,10 @@ Notification::~Notification()
{
}
static NotificationServerConnection& notification_server_connection()
{
static NotificationServerConnection* connection;
if (!connection)
connection = &NotificationServerConnection::construct().leak_ref();
return *connection;
}
void Notification::show()
{
notification_server_connection().post_message(Messages::NotificationServer::ShowNotification(m_text, m_title));
auto connection = NotificationServerConnection::construct();
connection->post_message(Messages::NotificationServer::ShowNotification(m_text, m_title));
}
}