RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:47:35 +00:00
Code Issues Activity Actions

LibJS: Move JobCallback functions out-of-line

Browse source 
This allows JobCallback.h to not include Runtime/AbstractOperations.h
and FunctionObject.h.
This commit is contained in:
Andreas Kling 2022-11-23 11:32:45 +01:00 • committed by Linus Groh
parent 20e51025bb
commit 96cbf368bd
4 changed files with 36 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibJS/CMakeLists.txt
View file

@ -136,6 +136,7 @@ set(SOURCES
Runtime/IteratorOperations.cpp Runtime/IteratorOperations.cpp
Runtime/IteratorPrototype.cpp Runtime/IteratorPrototype.cpp
Runtime/JSONObject.cpp Runtime/JSONObject.cpp
Runtime/JobCallback.cpp
Runtime/Map.cpp Runtime/Map.cpp
Runtime/MapConstructor.cpp Runtime/MapConstructor.cpp
Runtime/MapIterator.cpp Runtime/MapIterator.cpp

1
Userland/Libraries/LibJS/Runtime/FinalizationRegistryPrototype.cpp
View file

@ -5,6 +5,7 @@
*/ */
#include <AK/TypeCasts.h> #include <AK/TypeCasts.h>
#include <LibJS/Runtime/AbstractOperations.h>
#include <LibJS/Runtime/FinalizationRegistryPrototype.h> #include <LibJS/Runtime/FinalizationRegistryPrototype.h>
namespace JS { namespace JS {

30
Userland/Libraries/LibJS/Runtime/JobCallback.cpp Normal file
View file

@ -0,0 +1,30 @@
/*
* Copyright (c) 2021-2022, Linus Groh <linusg@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibJS/Runtime/AbstractOperations.h>
#include <LibJS/Runtime/FunctionObject.h>
#include <LibJS/Runtime/JobCallback.h>
namespace JS {
// 9.5.2 HostMakeJobCallback ( callback ), https://tc39.es/ecma262/#sec-hostmakejobcallback
JobCallback make_job_callback(FunctionObject& callback)
{
// 1. Return the JobCallback Record { [[Callback]]: callback, [[HostDefined]]: empty }.
return { make_handle(&callback) };
}
// 9.5.3 HostCallJobCallback ( jobCallback, V, argumentsList ), https://tc39.es/ecma262/#sec-hostcalljobcallback
ThrowCompletionOr<Value> call_job_callback(VM& vm, JobCallback& job_callback, Value this_value, MarkedVector<Value> arguments_list)
{
// 1. Assert: IsCallable(jobCallback.[[Callback]]) is true.
VERIFY(!job_callback.callback.is_null());
// 2. Return ? Call(jobCallback.[[Callback]], V, argumentsList).
return call(vm, job_callback.callback.cell(), this_value, move(arguments_list));
}
}

22
Userland/Libraries/LibJS/Runtime/JobCallback.h
View file

@ -6,9 +6,9 @@
#pragma once #pragma once
#include <LibJS/Runtime/AbstractOperations.h> #include <AK/OwnPtr.h>
#include <LibJS/Heap/Handle.h>
#include <LibJS/Runtime/Completion.h> #include <LibJS/Runtime/Completion.h>
#include <LibJS/Runtime/FunctionObject.h>
namespace JS { namespace JS {
@ -22,21 +22,7 @@ struct JobCallback {
OwnPtr<CustomData> custom_data { nullptr }; OwnPtr<CustomData> custom_data { nullptr };
}; };
// 9.5.2 HostMakeJobCallback ( callback ), https://tc39.es/ecma262/#sec-hostmakejobcallback JobCallback make_job_callback(FunctionObject& callback);
inline JobCallback make_job_callback(FunctionObject& callback) ThrowCompletionOr<Value> call_job_callback(VM&, JobCallback&, Value this_value, MarkedVector<Value> arguments_list);
{
// 1. Return the JobCallback Record { [[Callback]]: callback, [[HostDefined]]: empty }.
return { make_handle(&callback) };
}
// 9.5.3 HostCallJobCallback ( jobCallback, V, argumentsList ), https://tc39.es/ecma262/#sec-hostcalljobcallback
inline ThrowCompletionOr<Value> call_job_callback(VM& vm, JobCallback& job_callback, Value this_value, MarkedVector<Value> arguments_list)
{
// 1. Assert: IsCallable(jobCallback.[[Callback]]) is true.
VERIFY(!job_callback.callback.is_null());
// 2. Return ? Call(jobCallback.[[Callback]], V, argumentsList).
return call(vm, job_callback.callback.cell(), this_value, move(arguments_list));
}
} }