From 96db8a061bbfa0a56ad7d5ef1b0b32e2e83089b1 Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Tue, 25 Jan 2022 00:06:49 +0000 Subject: [PATCH] LibJS: Correct FormatTimeZoneOffsetString arg in CreateTemporalTimeZone This is an editorial change in the Temporal spec (accidentally marked normative). See: https://github.com/tc39/proposal-temporal/commit/3039c98 --- Userland/Libraries/LibJS/Runtime/Temporal/TimeZone.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/TimeZone.cpp b/Userland/Libraries/LibJS/Runtime/Temporal/TimeZone.cpp index 5e1cc9667e..c627e05c7e 100644 --- a/Userland/Libraries/LibJS/Runtime/Temporal/TimeZone.cpp +++ b/Userland/Libraries/LibJS/Runtime/Temporal/TimeZone.cpp @@ -90,8 +90,7 @@ ThrowCompletionOr create_temporal_time_zone(GlobalObject& global_obje } // 5. Else, else { - // a. Set object.[[Identifier]] to ! FormatTimeZoneOffsetString(identifier). - // TODO: `identifier` is wrong here. See: https://github.com/tc39/proposal-temporal/pull/2010 + // a. Set object.[[Identifier]] to ! FormatTimeZoneOffsetString(offsetNanosecondsResult.[[Value]]). object->set_identifier(format_time_zone_offset_string(offset_nanoseconds_result.value())); // b. Set object.[[OffsetNanoseconds]] to offsetNanosecondsResult.[[Value]].