mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 01:57:45 +00:00
LibWeb+WebContent: Do not reference-count file request objects
There is currently a memory leak with these file request objects due to the callback on_file_request_finish referencing itself in its capture list. This object does not need to be reference counted or allocated on the heap. It is only ever stored in a HashMap until a response is received from the browser, and it is not shared.
This commit is contained in:
parent
9bb469f324
commit
96f409ec1e
9 changed files with 29 additions and 26 deletions
|
@ -195,7 +195,7 @@ public:
|
|||
virtual void page_did_update_resource_count(i32) { }
|
||||
virtual void page_did_close_browsing_context(HTML::BrowsingContext const&) { }
|
||||
|
||||
virtual void request_file(NonnullRefPtr<FileRequest>&) = 0;
|
||||
virtual void request_file(FileRequest) = 0;
|
||||
|
||||
// https://html.spec.whatwg.org/multipage/input.html#show-the-picker,-if-applicable
|
||||
virtual void page_did_request_file_picker(WeakPtr<DOM::EventTarget>, [[maybe_unused]] bool multiple) {};
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue