RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 06:17:35 +00:00
Code Issues Activity Actions

LibWeb+WebContent: Do not reference-count file request objects

Browse source 
There is currently a memory leak with these file request objects due to
the callback on_file_request_finish referencing itself in its capture
list. This object does not need to be reference counted or allocated on
the heap. It is only ever stored in a HashMap until a response is
received from the browser, and it is not shared.
This commit is contained in:
Timothy Flynn 2023-01-30 16:35:47 -05:00 • committed by Linus Groh
parent 9bb469f324
commit 96f409ec1e
9 changed files with 29 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Utilities/headless-browser.cpp
View file

@ -236,10 +236,10 @@ public:
{
}
void request_file(NonnullRefPtr<Web::FileRequest>& request) override
void request_file(Web::FileRequest request) override
{
auto const file = Core::System::open(request->path(), O_RDONLY);
request->on_file_request_finish(file);
auto const file = Core::System::open(request.path(), O_RDONLY);
request.on_file_request_finish(file);
}
private: