RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-15 07:04:59 +00:00
Code Issues Activity Actions

LibWeb: Return an Optional<String> from HTMLToken::attribute

Browse source 
Move away from using a nullable StringView.
This commit is contained in:
Shannon Booth 2023-11-11 09:27:43 +13:00 • committed by Andreas Kling
parent 72bb928dd8
commit 96fc1741b5
2 changed files with 5 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/HTML/Parser/HTMLToken.h
View file

@ -245,7 +245,7 @@ public:
}
}
StringView attribute(FlyString const& attribute_name) const
Optional<String> attribute(FlyString const& attribute_name) const
{
if (auto result = raw_attribute(attribute_name); result.has_value())
return result->value;
@ -268,7 +268,7 @@ public:
bool has_attribute(FlyString const& attribute_name) const
{
return !attribute(attribute_name).is_null();
return attribute(attribute_name).has_value();
}
void adjust_tag_name(FlyString const& old_name, FlyString const& new_name)