RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 14:28:12 +00:00
Code Issues Activity Actions

chgrp: Add support for multiple file paths

Browse source
This commit is contained in:
Tim Ledbetter 2023-06-06 20:04:11 +01:00 • committed by Andreas Kling
parent 8afe5ce718
commit 96fecc434c
2 changed files with 19 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Base/usr/share/man/man1/chgrp.md
View file

@ -1,12 +1,12 @@
## Name ## Name
chgrp - change group ownership of file chgrp - change group ownership of files
## Synopsis ## Synopsis
```**sh ```**sh
$ chgrp <gid> <path> $ chgrp <gid> <path...>
$ chgrp <name> <path> $ chgrp <name> <path...>
``` ```
## Description ## Description

24
Userland/Utilities/chgrp.cpp
View file

@ -14,14 +14,14 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
TRY(Core::System::pledge("stdio rpath chown")); TRY(Core::System::pledge("stdio rpath chown"));
StringView gid_arg; StringView gid_arg;
StringView path {}; Vector<StringView> paths;
bool dont_follow_symlinks = false; bool dont_follow_symlinks = false;
Core::ArgsParser args_parser; Core::ArgsParser args_parser;
args_parser.set_general_help("Change the owning group for a file or directory."); args_parser.set_general_help("Change the owning group for files or directories.");
args_parser.add_option(dont_follow_symlinks, "Don't follow symlinks", "no-dereference", 'h'); args_parser.add_option(dont_follow_symlinks, "Don't follow symlinks", "no-dereference", 'h');
args_parser.add_positional_argument(gid_arg, "Group ID", "gid"); args_parser.add_positional_argument(gid_arg, "Group ID", "gid");
args_parser.add_positional_argument(path, "Path to file", "path"); args_parser.add_positional_argument(paths, "Paths to files", "paths");
args_parser.parse(arguments); args_parser.parse(arguments);
gid_t new_gid = -1; gid_t new_gid = -1;
@ -43,11 +43,19 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
new_gid = group->gr_gid; new_gid = group->gr_gid;
} }
if (dont_follow_symlinks) { auto has_errors = false;
TRY(Core::System::lchown(path, -1, new_gid)); for (auto path : paths) {
} else { ErrorOr<void> maybe_error;
TRY(Core::System::chown(path, -1, new_gid)); if (dont_follow_symlinks)
maybe_error = Core::System::lchown(path, -1, new_gid);
else
maybe_error = Core::System::chown(path, -1, new_gid);
if (maybe_error.is_error()) {
has_errors = true;
warnln("Changing group of '{}'. {}", path, maybe_error.release_error());
}
} }
return 0; return has_errors ? 1 : 0;
} }