RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 22:07:35 +00:00
Code Issues Activity Actions

LibJS: Don't use MarkedValueList in PromiseValueList

Browse source 
Instead, override visit_edges() and mark the values like any other Cell
subclass would.

This makes PromiseValueList play nice with zombification.
This commit is contained in:
Andreas Kling 2021-09-11 22:16:30 +02:00
parent 2253235a0f
commit 971dc44ed3
3 changed files with 19 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibJS/Runtime/PromiseConstructor.cpp
View file

@ -111,7 +111,7 @@ static Value perform_promise_common(GlobalObject& global_object, Object& iterato
return {};
}
values->values.append(js_undefined());
values->values().append(js_undefined());
auto next_promise = vm.call(promise_resolve.as_function(), constructor, next_value);
if (vm.exception())
@ -135,7 +135,7 @@ static Value perform_promise_all(GlobalObject& global_object, Object& iterator_r
return perform_promise_common(
global_object, iterator_record, constructor, result_capability, promise_resolve,
[&](PromiseValueList& values) -> Value {
auto values_array = Array::create_from(global_object, values.values);
auto values_array = Array::create_from(global_object, values.values());
(void)vm.call(*result_capability.resolve, js_undefined(), values_array);
if (vm.exception())
@ -159,7 +159,7 @@ static Value perform_promise_all_settled(GlobalObject& global_object, Object& it
return perform_promise_common(
global_object, iterator_record, constructor, result_capability, promise_resolve,
[&](PromiseValueList& values) -> Value {
auto values_array = Array::create_from(global_object, values.values);
auto values_array = Array::create_from(global_object, values.values());
(void)vm.call(*result_capability.resolve, js_undefined(), values_array);
if (vm.exception())
@ -186,7 +186,7 @@ static Value perform_promise_any(GlobalObject& global_object, Object& iterator_r
return perform_promise_common(
global_object, iterator_record, constructor, result_capability, promise_resolve,
[&](PromiseValueList& errors) -> Value {
auto errors_array = Array::create_from(global_object, errors.values);
auto errors_array = Array::create_from(global_object, errors.values());
auto* error = AggregateError::create(global_object);
error->define_property_or_throw(vm.names.errors, { .value = errors_array, .writable = true, .enumerable = false, .configurable = true });