mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 07:57:46 +00:00
LibCrypto: Avoid unaligned reads in GHash constructor
The fact that this always reads 16 bytes from the input byte stream for the key data is still a bit on the suspicious side, but at least it won't crash UBSAN anymore.
This commit is contained in:
parent
3058ff1500
commit
97444f0a25
1 changed files with 5 additions and 2 deletions
|
@ -6,6 +6,7 @@
|
|||
|
||||
#pragma once
|
||||
|
||||
#include <AK/ByteReader.h>
|
||||
#include <AK/String.h>
|
||||
#include <AK/Types.h>
|
||||
#include <LibCrypto/Hash/HashFunction.h>
|
||||
|
@ -35,8 +36,10 @@ public:
|
|||
|
||||
explicit GHash(const ReadonlyBytes& key)
|
||||
{
|
||||
for (size_t i = 0; i < 16; i += 4)
|
||||
m_key[i / 4] = AK::convert_between_host_and_big_endian(*(const u32*)(key.offset(i)));
|
||||
VERIFY(key.size() >= 16);
|
||||
for (size_t i = 0; i < 16; i += 4) {
|
||||
m_key[i / 4] = AK::convert_between_host_and_big_endian(ByteReader::load32(key.offset(i)));
|
||||
}
|
||||
}
|
||||
|
||||
constexpr static size_t digest_size() { return TagType::Size; }
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue