RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 21:07:34 +00:00
Code Issues Activity Actions

LibWeb+Ladybird+Userland: Port window.[alert,confirm,prompt] to String

Browse source 
LibGUI and WebDriver (read: JSON) API boundaries use DeprecatedString,
so that is as far as these changes can reach.

The one change which isn't just a DeprecatedString to String replacement
is handling the "null" prompt response. We previously checked for the
null DeprecatedString, whereas we now represent this as an empty
Optional<String>.
This commit is contained in:
Timothy Flynn 2023-03-13 17:30:51 -04:00 • committed by Linus Groh
parent b4d3fea002
commit 97536e4684
18 changed files with 85 additions and 85 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Services/WebContent/PageHost.h
View file

@ -46,7 +46,7 @@ public:
void alert_closed();
void confirm_closed(bool accepted);
void prompt_closed(DeprecatedString response);
void prompt_closed(Optional<String> response);
private:
// ^PageClient
@ -83,10 +83,10 @@ private:
virtual void page_did_start_loading(const URL&, bool) override;
virtual void page_did_create_main_document() override;
virtual void page_did_finish_loading(const URL&) override;
virtual void page_did_request_alert(DeprecatedString const&) override;
virtual void page_did_request_confirm(DeprecatedString const&) override;
virtual void page_did_request_prompt(DeprecatedString const&, DeprecatedString const&) override;
virtual void page_did_request_set_prompt_text(DeprecatedString const&) override;
virtual void page_did_request_alert(String const&) override;
virtual void page_did_request_confirm(String const&) override;
virtual void page_did_request_prompt(String const&, String const&) override;
virtual void page_did_request_set_prompt_text(String const&) override;
virtual void page_did_request_accept_dialog() override;
virtual void page_did_request_dismiss_dialog() override;
virtual void page_did_change_favicon(Gfx::Bitmap const&) override;