RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:17:44 +00:00
Code Issues Activity Actions

Ladybird: Turn initialize_global_object() into a regular initialize()

Browse source 
See: cfa5885
This commit is contained in:
Luke Wilde 2022-08-28 18:08:12 +01:00 • committed by Andrew Kaster
parent 1e7d4bc089
commit 9789d8b769
3 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Ladybird/ConsoleClient.cpp
View file

@ -35,7 +35,7 @@ ConsoleClient::ConsoleClient(JS::Console& console, WeakPtr<JS::Interpreter> inte
// It gets removed immediately after creating the interpreter in Document::interpreter(). // It gets removed immediately after creating the interpreter in Document::interpreter().
auto& eso = verify_cast<Web::HTML::EnvironmentSettingsObject>(*m_interpreter->realm().host_defined()); auto& eso = verify_cast<Web::HTML::EnvironmentSettingsObject>(*m_interpreter->realm().host_defined());
vm.push_execution_context(eso.realm_execution_context()); vm.push_execution_context(eso.realm_execution_context());
console_global_object->initialize_global_object(realm); console_global_object->initialize(realm);
vm.pop_execution_context(); vm.pop_execution_context();
m_console_global_object = JS::make_handle(console_global_object); m_console_global_object = JS::make_handle(console_global_object);

4
Ladybird/ConsoleGlobalObject.cpp
View file

@ -21,9 +21,9 @@ ConsoleGlobalObject::ConsoleGlobalObject(JS::Realm& realm, Web::Bindings::Window
{ {
} }
void ConsoleGlobalObject::initialize_global_object(JS::Realm& realm) void ConsoleGlobalObject::initialize(JS::Realm& realm)
{ {
Base::initialize_global_object(realm); Base::initialize(realm);
// $0 magic variable // $0 magic variable
define_native_accessor(realm, "$0", inspected_node_getter, nullptr, 0); define_native_accessor(realm, "$0", inspected_node_getter, nullptr, 0);

3
Ladybird/ConsoleGlobalObject.h
View file

@ -24,6 +24,7 @@ class ConsoleGlobalObject final : public JS::GlobalObject {
public: public:
ConsoleGlobalObject(JS::Realm&, Web::Bindings::WindowObject&); ConsoleGlobalObject(JS::Realm&, Web::Bindings::WindowObject&);
virtual void initialize(JS::Realm&) override;
virtual ~ConsoleGlobalObject() override = default; virtual ~ConsoleGlobalObject() override = default;
virtual JS::ThrowCompletionOr<Object*> internal_get_prototype_of() const override; virtual JS::ThrowCompletionOr<Object*> internal_get_prototype_of() const override;
@ -38,8 +39,6 @@ public:
virtual JS::ThrowCompletionOr<bool> internal_delete(JS::PropertyKey const& name) override; virtual JS::ThrowCompletionOr<bool> internal_delete(JS::PropertyKey const& name) override;
virtual JS::ThrowCompletionOr<JS::MarkedVector<JS::Value>> internal_own_property_keys() const override; virtual JS::ThrowCompletionOr<JS::MarkedVector<JS::Value>> internal_own_property_keys() const override;
virtual void initialize_global_object(JS::Realm&) override;
private: private:
virtual void visit_edges(Visitor&) override; virtual void visit_edges(Visitor&) override;